Bug 265749
| Summary: | REGRESSION(268561@main): generate-bindings-all.pl: [CMake] doesn't account for certain IDL changes | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Anne van Kesteren <annevk> |
| Component: | Tools / Tests | Assignee: | Fujii Hironori <fujii.hironori> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, fujii.hironori, mcatanzaro, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=261364 | ||
Anne van Kesteren
https://github.com/WebKit/WebKit/pull/21232 is failing to compile across the Linux bots due to what appears to be the incremental build not realizing the IDL changes are significant.
For instance:
In file included from /app/webkit/WebKitBuild/WPE/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-109.cpp:2:
/app/webkit/WebKitBuild/WPE/Release/WebCore/DerivedSources/JSPerformanceNavigationTiming.cpp: In function ‘JSC::EncodedJSValue WebCore::jsPerformanceNavigationTimingPrototypeFunction_toJSONBody(JSC::JSGlobalObject*, JSC::CallFrame*, JSPerformanceNavigationTiming*)’:
/app/webkit/WebKitBuild/WPE/Release/WebCore/DerivedSources/JSPerformanceNavigationTiming.cpp:437:35: error: ‘serverTimingEnabled’ is not a member of ‘WebCore::DeprecatedGlobalSettings’
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Fujii Hironori
The generated JSPerformanceNavigationTiming.dep contains the following line:
> JSPerformanceNavigationTiming.h : PerformanceResourceTiming.idl PerformanceEntry.idl
If PerformanceResourceTiming.idl is modified, JSPerformanceNavigationTiming.{h,cpp} should be regenerated.
This is a regression of 268561@main (bug#261364).
Fujii Hironori
Pull request: https://github.com/WebKit/WebKit/pull/21299
Michael Catanzaro
Is there a reason the dependency file doesn't simply also contain JSPerformanceNavigationTiming.cpp? Why only regenerate the header and not also the generated source file?
EWS
Committed 271510@main (e4ad7f1cf28a): <https://commits.webkit.org/271510@main>
Reviewed commits have been landed. Closing PR #21299 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/119153459>
Fujii Hironori
(In reply to Michael Catanzaro from comment #3)
> Is there a reason the dependency file doesn't simply also contain
> JSPerformanceNavigationTiming.cpp? Why only regenerate the header and not
> also the generated source file?
Oh, I missed your comment.
generate-bindings.pl gerenates both .cpp and .h at the same time.
So, it doesn't need .cpp line in the .dep file.
And, generate-bindings-all.pl process only the file line of .dep files at the moment.
https://github.com/WebKit/WebKit/blob/906329430eb27e345bf525433f393e8a3912936a/Source/WebCore/bindings/scripts/generate-bindings-all.pl#L201