Bug 265813
| Summary: | [WPE][GTK] Remove pkg-config use from FindLibBacktrace.cmake | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro, vitaly |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=262104 | ||
Michael Catanzaro
Currently FindLibBacktrace.cmake uses pkg-config expecting to find a backtrace.pc, but I don't think libbacktrace from https://github.com/ianlancetaylor/libbacktrace actually installs any such pkg-config file. At least, I've failed to find any pkg-config file in the source repo, and I also couldn't find any code that generates it. So, let's remove this and rely on CMake heuristics to hopefully find the library.
Also, I notice that libbacktrace has no upstream releases on GitHub, so I think it's too soon for it to be packaged in distros or enabled by default. It's actually not clear if any releases of this library are ever planned. It seems that upstream considers every commit to be "version 1.0" rather than picking a commit to be a release, which is not confidence-inspiring. This could probably be easily fixed, but in the meantime, let's leave this option off by default for now. Hopefully eventually it will become more clear whether libbacktrace is serious about being packaged by distros or not.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
(This is a continuation from discussion in bug #262104.)
Michael Catanzaro
Pull request: https://github.com/WebKit/WebKit/pull/21294
EWS
Committed 272292@main (0ff5cc83058a): <https://commits.webkit.org/272292@main>
Reviewed commits have been landed. Closing PR #21294 and removing active labels.