Bug 26675

Summary: Allow custom memory allocation control for JavaScriptCore's Register class
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on: 26686    
Bug Blocks:    
Attachments:
Description Flags
proposed patch
none
updated proposed patch mjs: review+

Zoltan Horvath
Reported 2009-06-24 05:10:52 PDT
Inherits Register class from FastAllocBase because it has been instantiated by 'new' in JavaScriptCore/runtime/JSVariableObject.h:149.
Attachments
proposed patch (1.07 KB, patch)
2009-06-24 05:14 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
updated proposed patch (1.06 KB, patch)
2009-06-24 11:25 PDT, Zoltan Horvath 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2009-06-24 05:14:37 PDT
Created attachment 31782 [details] proposed patch
Darin Adler
Comment 2 2009-06-24 09:54:23 PDT
Comment on attachment 31782 [details] proposed patch Explicit qualification by WTF:: should not be necessary. The pattern in WTF is that we put "using" statements into the files. It's a bit unusual for C++ code but I've been convinced by the other WTF developers that it's the right pattern. So we should patch FastAllocBase to include: using WTF::FastAllocBase; And call the class just FastAllocBase everywhere we use it.
Zoltan Horvath
Comment 3 2009-06-24 11:25:41 PDT
Created attachment 31793 [details] updated proposed patch
Zoltan Horvath
Comment 4 2009-06-24 11:33:28 PDT
I've filed a bug #26686 with FastAllocBase.h modifications and unnecessary WTF:: removes. I've updated my uploaded bugs also: bug #26676 ; bug #26677 and this also.
Maciej Stachowiak
Comment 5 2009-06-24 12:15:51 PDT
Comment on attachment 31793 [details] updated proposed patch r=me
Eric Seidel (no email)
Comment 6 2009-06-24 16:54:29 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/interpreter/Register.h Committed r45121 http://trac.webkit.org/changeset/45121
David Levin
Comment 7 2009-06-24 18:10:06 PDT
This patch need a fix to build: http://trac.webkit.org/changeset/45128
Note You need to log in before you can comment on or make changes to this bug.