Bug 277572
| Summary: | [WebDriver] Stop using the deprecated CGWindowListCreateImage for viewport snapshots | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Qianlang Chen <qianlangchen> |
| Component: | WebDriver | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bburg, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Qianlang Chen
The patch https://github.com/WebKit/WebKit/pull/31013 made WebDriver use the deprecated CGWindowListCreateImage function to take viewport snapshots.
- This was done to bypass the bug with CGSHWCaptureWindowList, the current way of taking viewport snapshots, which takes screenshots with the windows' rounded corners because its kCGSCaptureIgnoreGlobalClipShape option is bugged and has no effect. This bug introduced flakiness in WPT tests that the above patch aimed to resolve.
- CGWindowListCreateImage was deprecated in favor of the ScreenCaptureKit (https://developer.apple.com/documentation/screencapturekit).
Once CGSHWCaptureWindowList gets its bug fixed, we should consider switching back to using that to take viewport snapshots, as deprecated functions are prone to being removed or unmaintained later.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/133093672>