Bug 284226
| Summary: | [popover] Integrate with anchor positioning | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> |
| Component: | Layout and Rendering | Assignee: | Antti Koivisto <koivisto> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, fantasai.bugs, ian, kiet.ho, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://github.com/web-platform-tests/wpt/pull/53022 | ||
| Bug Depends on: | |||
| Bug Blocks: | 291856, 294260 | ||
Tim Nguyen (:ntim)
See https://github.com/whatwg/html/pull/10728 for details.
- Popover invokers (set declaratively or imperatively) now create an [implicit anchor element](https://www.w3.org/TR/css-anchor-position-1/#implicit-anchor-element) reference for that popover.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/141094328>
fantasai
Some code pointers from Tim:
Implicit anchor for popovers:
https://searchfox.org/wubkat/search?q=symbol:_ZNK7WebCore11PopoverData7invokerEv&redirect=false
Maps from names to elements here -- these would not work with implicit anchor (since the name is auto)
https://searchfox.org/wubkat/rev/87ca7ad48ea92e0a1972e92dc8b28f3df63e89fa/Source/WebCore/style/AnchorPositionEvaluator.h#63
These conditionals need to be updated:
https://searchfox.org/wubkat/search?q=anchorNames%28%29&path=&case=false®exp=false
Antti Koivisto
Pull request: https://github.com/WebKit/WebKit/pull/46495
EWS
Committed 295995@main (6bea8210e2b5): <https://commits.webkit.org/295995@main>
Reviewed commits have been landed. Closing PR #46495 and removing active labels.
Antti Koivisto
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/53022