Bug 288208
| Summary: | Remove mac-ventura* platform folders, Ventura/+ test expectations. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ben Schwartz <ben_schwartz> |
| Component: | Tools / Tests | Assignee: | Ben Schwartz <ben_schwartz> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ben Schwartz
WebKit has deprecated building and testing on macOS Ventura. We should remove Ventura-specific layout test expectations and baseline folders.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/145303446>
Ben Schwartz
Pull request: https://github.com/WebKit/WebKit/pull/41068
EWS
Committed 290956@main (41e873537685): <https://commits.webkit.org/290956@main>
Reviewed commits have been landed. Closing PR #41068 and removing active labels.
Jonathan Bedard
This removal was done wrong. Ventura+ should have been removed, but the expectation for the failures should have been kept.
Sounds like Karl is filing these now.
Ben Schwartz
The tag "Ventura+" was removed from all expectations. I then audited the tests that had Ventura+ according to the results in the results database to make sure they were still failing. If they were not, I removed the entire expectation. It's possible I made a mistake or two in my audit -- do you have any examples of tests that are newly unexpectedly failing after my change?
If something is failing and it's not being reported to results database (perhaps only on EWS?), then this could indicate an issue with how infrastructure is reporting these failures.