Bug 28827

Summary: SVGSVGElement.unsuspendRedraw() shouldn't throw
Product: WebKit Reporter: Cameron McCormack (:heycam) <heycam>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Trivial CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch v1 none

Cameron McCormack (:heycam)
Reported 2009-08-28 23:45:42 PDT
Erratum removes the exception on unsuspendRedraw(): http://www.w3.org/2003/01/REC-SVG11-20030114-errata#remove_exception_on_unsuspendredraw
Attachments
Patch v1 (2.34 KB, patch)
2009-08-28 23:53 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Cameron McCormack (:heycam)
Comment 1 2009-08-28 23:53:30 PDT
Created attachment 38773 [details] Patch v1 Remove the exception. (The IDL was using "setter raises" erroneously, too.)
Eric Seidel (no email)
Comment 2 2009-08-31 03:18:39 PDT
Comment on attachment 38773 [details] Patch v1 Please link to the errata in your ChangeLog in the future. :) ChangeLogs are much quicker lookup than pulling up the bug.
Eric Seidel (no email)
Comment 3 2009-08-31 03:30:03 PDT
Comment on attachment 38773 [details] Patch v1 Rejecting patch 38773 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
Eric Seidel (no email)
Comment 4 2009-08-31 03:48:18 PDT
Comment on attachment 38773 [details] Patch v1 Flakey Test: Testing 11178 test cases. media/video-source-add-src.html -> crashed
Eric Seidel (no email)
Comment 5 2009-08-31 04:01:26 PDT
(In reply to comment #4) > (From update of attachment 38773 [details]) > Flakey Test: > Testing 11178 test cases. > media/video-source-add-src.html -> crashed Logged as bug 28845.
Eric Seidel (no email)
Comment 6 2009-08-31 04:06:41 PDT
Comment on attachment 38773 [details] Patch v1 Clearing flags on attachment: 38773 Committed r47890: <http://trac.webkit.org/changeset/47890>
Eric Seidel (no email)
Comment 7 2009-08-31 04:06:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.