Bug 289953
| Summary: | [GTK][WPE] Use _LIBCPP_HARDENING_MODE with newer libc++ versions | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | CMake | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=266396 | ||
Adrian Perez
With libc++ 20.x we hit this issue when enabling C++ library assertions:
# error "_LIBCPP_ENABLE_ASSERTIONS has been removed, please use _LIBCPP_HARDENING_MODE instead"
Let's try to detect whether the version in use needs the new macro, and use the old one for older releases.
Originally reported here: https://github.com/WebKit/WebKit/pull/21785#issuecomment-2731023649
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/42616
EWS
Committed 292304@main (7ffc29624258): <https://commits.webkit.org/292304@main>
Reviewed commits have been landed. Closing PR #42616 and removing active labels.