Bug 29328

Summary: ecma/Date/15.9.5.10-1.js fails every night at midnight
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dbates, kent.hansen, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 33297    
Attachments:
Description Flags
Patch eric: review-

Eric Seidel (no email)
Reported 2009-09-17 00:45:51 PDT
ecma/Date/15.9.5.10-1.js fails every night at midnight Or at least so I'm told. Example: http://build.webkit.org/builders/Leopard%20Intel%20Release%20%28Tests%29/builds/5062 Having this test be flakey will cause trouble for things which depend on the bots being green (like the commit-queue). bug 4930 and bug 7998 also mention this test as being date sensitive.
Attachments
Patch (1.36 KB, patch)
2010-01-12 00:00 PST, Adam Barth 		eric: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-09-17 00:47:25 PDT
I, for one, find this really annoying because I'm usually checking in code at midnight.
Eric Seidel (no email)
Comment 3 2010-01-11 23:38:27 PST
Bug 28041 is another test which fails at midnight. :(
Adam Barth
Comment 4 2010-01-12 00:00:49 PST
Created attachment 46343 [details] Patch
Eric Seidel (no email)
Comment 5 2010-01-12 00:02:56 PST
Comment on attachment 46343 [details] Patch It seems this may need a comment. Kent was thinking about syncing us with mozilla's tip of tree.
Eric Seidel (no email)
Comment 6 2010-01-12 00:04:28 PST
Comment on attachment 46343 [details] Patch Wrong bug.
Csaba Osztrogonác
Comment 7 2010-01-27 07:58:14 PST
Patch committed http://trac.webkit.org/changeset/53118 by abarth 2 weeks ago, so it was resolved/fixed.
Note You need to log in before you can comment on or make changes to this bug.