Bug 296710
| Summary: | Extend Fetch to accept local connections | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ian Gower <i_gower> |
| Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | beidson, commit-queue, jenner, jer.noble, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 297626 | ||
| Bug Blocks: | 250607 | ||
Ian Gower
Extend Fetch to accept local connections
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ian Gower
rdar://154439024
Ian Gower
Pull request: https://github.com/WebKit/WebKit/pull/48741
EWS
Committed 298921@main (d4e2bd45ea23): <https://commits.webkit.org/298921@main>
Reviewed commits have been landed. Closing PR #48741 and removing active labels.
WebKit Commit Bot
Re-opened since this is blocked by bug 297626
EWS
Committed 298927@main (5b46346c7d14): <https://commits.webkit.org/298927@main>
Reviewed commits have been landed. Closing PR #49624 and removing active labels.
Robert Jenner
https://commits.webkit.org/298921@main broke all of the builds with the following error:
Undefined symbols for architecture x86_64:
"WebCore::ScriptWrappable::~ScriptWrappable()", referenced from:
WebCore::Geolocation::~Geolocation() in
ld: symbol(s) not found for architecture x86_64
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
Example build failure: https://build.webkit.org/#/builders/1223/builds/10893
As such, we had to revert the change, and that was reverted in: https://commits.webkit.org/298927@main
Robert Jenner
Another thing to note:
On the initial PR: https://github.com/WebKit/WebKit/pull/48741
It did fail style checker, and it also failed merge-queue with the error that we are seeing. However, it was then landed with unsafe-merge-queue. Not a huge deal, but it is something to double check and be aware of.
Ian Gower
Pull request: https://github.com/WebKit/WebKit/pull/49639
EWS
Committed 298981@main (a3bc93f96c80): <https://commits.webkit.org/298981@main>
Reviewed commits have been landed. Closing PR #49639 and removing active labels.
Jer Noble
This was the wrong fix to resolve that error. `#include "ScriptWrappableInlines.h"` should have been added to Geolocation.cpp.