Bug 29677

Summary: Guard QX11Info include with Q_WS_X11
Product: WebKit Reporter: Norbert Leser <norbert.leser>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hausmann, kenneth, laszlo.gombos, ossy, tonikitoo, yongjun.zhang
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 27065    
Attachments:
Description Flags
QX11Info patch none

Norbert Leser
Reported 2009-09-23 05:19:56 PDT
Created attachment 39990 [details] QX11Info patch Need to guard QX11Info include with Q_WS_X11. That class may not be available (in QT 4.5 for Symbian, for instance). Completes fixes in r48627 and r48604.
Attachments
QX11Info patch (1.46 KB, patch)
2009-09-23 05:19 PDT, Norbert Leser 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2009-09-23 05:50:30 PDT
Norbert, you don't need reviews for build fixes like this one :-) Feel free to commit! Just write "Unreviewed Qt build fix" in the ChangeLog
Tor Arne Vestbø
Comment 2 2009-09-23 05:55:51 PDT
Comment on attachment 39990 [details] QX11Info patch Kennth is right, but r=me
Norbert Leser
Comment 3 2009-09-23 06:00:43 PDT
(In reply to comment #2) > (From update of attachment 39990 [details]) > Kennth is right, but r=me I don't have commit rights - thus, someone else please pick it up. The fix seems trivial, and in this case, I assume it is - still, these sort of changes can easily break the build on certain platforms, under certain conditions. I would caution to treat these as pass-through / non-review fixes.
WebKit Commit Bot
Comment 4 2009-09-23 06:08:55 PDT
Comment on attachment 39990 [details] QX11Info patch Rejecting patch 39990 from commit-queue. kenneth.christiansen@openbossa.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.
Kenneth Rohde Christiansen
Comment 5 2009-09-23 06:15:03 PDT
kenneth@webkit.org is an alias for kenneth.christiansen@openbossa.org Committer("Kenneth Rohde Christiansen", "kenneth@webkit.org"), Should I add both or ?
Kenneth Rohde Christiansen
Comment 6 2009-09-23 06:21:20 PDT
Comment on attachment 39990 [details] QX11Info patch Let's try again! I changed my bugzilla e-mail.
WebKit Commit Bot
Comment 7 2009-09-23 09:23:54 PDT
Comment on attachment 39990 [details] QX11Info patch Clearing flags on attachment: 39990 Committed r48676: <http://trac.webkit.org/changeset/48676>
WebKit Commit Bot
Comment 8 2009-09-23 09:23:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.