Bug 299921
| Summary: | -epub-* properties shouldn't create webkit-cased IDL attributes | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Karl Dubost <karlcow> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | koivisto, sam, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar, WPTImpact |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | http://wpt.live/css/css-conditional/js/CSS-supports-CSSStyleDeclaration.html | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=223141 | ||
Karl Dubost
The initial fix for this test was done in Bug 223141
There are still 19 failures to fix.
http://wpt.live/css/css-conditional/js/CSS-supports-CSSStyleDeclaration.html
http://wpt.fyi/css/css-conditional/js/CSS-supports-CSSStyleDeclaration.html
19 Fail including 9 about the prefix -epub-* which is converted as Epub by the test script.
Fail -epub-caption-side: _webkit_cased_attribute must only exist for -webkit- assert_false: expected false got true
Fail -epub-text-combine: _webkit_cased_attribute must only exist for -webkit- assert_false: expected false got true
Fail -epub-text-emphasis: _webkit_cased_attribute must only exist for -webkit- assert_false: expected false got true
Fail -epub-text-emphasis-color: _webkit_cased_attribute must only exist for -webkit- assert_false: expected false got true
Fail -epub-text-emphasis-style: _webkit_cased_attribute must only exist for -webkit- assert_false: expected false got true
Fail -epub-text-orientation: _webkit_cased_attribute must only exist for -webkit- assert_false: expected false got true
Fail -epub-text-transform: _webkit_cased_attribute must only exist for -webkit- assert_false: expected false got true
Fail -epub-word-break: _webkit_cased_attribute must only exist for -webkit- assert_false: expected false got true
Fail -epub-writing-mode: _webkit_cased_attribute must only exist for -webkit- assert_false: expected false got true
Fail font-display: _camel_cased_attribute v. CSS.supports assert_equals: expected true but got false
Fail font-display: _dashed_attribute v. CSS.supports assert_equals: expected true but got false
Fail inherits: _camel_cased_attribute v. CSS.supports assert_equals: expected true but got false
Fail initial-value: _camel_cased_attribute v. CSS.supports assert_equals: expected true but got false
Fail initial-value: _dashed_attribute v. CSS.supports assert_equals: expected true but got false
Fail size: _camel_cased_attribute v. CSS.supports assert_equals: expected true but got false
Fail src: _camel_cased_attribute v. CSS.supports assert_equals: expected true but got false
Fail syntax: _camel_cased_attribute v. CSS.supports assert_equals: expected true but got false
Fail unicode-range: _camel_cased_attribute v. CSS.supports assert_equals: expected true but got false
Fail unicode-range: _dashed_attribute v. CSS.supports assert_equals: expected true but got false
Firefox PASS on all tests
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/162161339>
Radar WebKit Bug Importer
<rdar://problem/162161344>
Karl Dubost
<rdar://problem/162161339>
Sam Sneddon [:gsnedders]
> The initial fix for this test was done in Bug 223141
That was one of three bugs; that we weren't consistently checking runtime feature flags. (Arguably that's many more bugs, because each difference is arguably a separate bug!)
> There are still 19 failures to fix.
These are two completely different failures which should be tracked separately:
The first is about -epub- properties appearing as EpubXXX, which is commented as such in the code: https://github.com/WebKit/WebKit/blob/97d0e362516b8739ab5739302541f7d7b150cbc8/Source/WebCore/css/scripts/process-css-properties.py#L3960-L3972
The second is about properties v. descriptors — historically WebKit (and Blink, given its shared origins) have had a single interface containing all properties and descriptors. Bug 238273 tracks that.
So let's use this bug for the first of these.