Bug 31445

Summary:

Rolling Chromium dependencies

Product:

WebKit

Reporter:

Yaar Schnitman <yaar>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dglazkov

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
deps role	none

Yaar Schnitman

Reported 2009-11-12 16:01:23 PST

Created attachment 43110 [details] Patch The chromium port's dependencies are a bit behind.

Attachments
Patch (815 bytes, patch) 2009-11-12 16:01 PST, Yaar Schnitman	no flags	Details Formatted Diff Diff
deps role (1.30 KB, patch) 2009-11-13 09:36 PST, Yaar Schnitman	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

WebKit Commit Bot

Comment 1 2009-11-12 17:50:37 PST

Comment on attachment 43110 [details] Patch Rejecting patch 43110 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11616 test cases. fast/workers/worker-close.html -> crashed Exiting early after 1 failures. 8388 tests run. 364.63s total testing time 8387 test cases (99%) succeeded 1 test case (<1%) crashed 3 test cases (<1%) had stderr output

Dimitri Glazkov (Google)

Comment 2 2009-11-12 18:19:03 PST

Comment on attachment 43110 [details] Patch let's try again.

WebKit Commit Bot

Comment 3 2009-11-12 18:36:02 PST

Comment on attachment 43110 [details] Patch Rejecting patch 43110 from commit-queue. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html

Dimitri Glazkov (Google)

Comment 4 2009-11-12 18:39:04 PST

Comment on attachment 43110 [details] Patch I am a bad boy. No ChangeLog.

Eric Seidel (no email)

Comment 5 2009-11-12 19:20:37 PST

Comment on attachment 43110 [details] Patch Filed bug 31453 about the crash.

Yaar Schnitman

Comment 6 2009-11-13 09:36:14 PST

Created attachment 43165 [details] deps role

Dimitri Glazkov (Google)

Comment 7 2009-11-13 09:40:27 PST

Comment on attachment 43165 [details] deps role ok.

WebKit Commit Bot

Comment 8 2009-11-13 09:50:18 PST

Comment on attachment 43165 [details] deps role Clearing flags on attachment: 43165 Committed r50948: <http://trac.webkit.org/changeset/50948>

WebKit Commit Bot

Comment 9 2009-11-13 09:50:24 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.