Bug 32113

Summary: [Qt] Use DirectConnection for the QNetworkReply in the QNetworkReplyHandler
Product: WebKit Reporter: Holger Freyther <zecke>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, markus, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Use direct Qt signal connections
none
[Qt] Followup for direct signals and slots connections in QNetworkReplyHandler hausmann: review+

Holger Freyther
Reported 2009-12-03 03:23:49 PST
Created attachment 44224 [details] Use direct Qt signal connections We should use DirectConnection to achieve a improvement in latency on network jobs. This also means that the loading will be more stable across different runs. The only possible problem is that it might cause crashes on Qt4.5 and Qt4.6... we will have to figure if it is crashing or not.
Attachments
Use direct Qt signal connections (3.14 KB, patch)
2009-12-03 03:23 PST, Holger Freyther 		no flags
DetailsFormatted DiffDiff
[Qt] Followup for direct signals and slots connections in QNetworkReplyHandler (2.57 KB, patch)
2009-12-15 01:10 PST, Holger Freyther 		hausmann: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2009-12-14 01:22:55 PST
style-queue ran check-webkit-style on attachment 44224 [details] without any errors.
Holger Freyther
Comment 2 2009-12-14 03:22:20 PST
Landed it in r52089. Waiting for the bot to run the tests before closing the bug.
Holger Freyther
Comment 3 2009-12-14 05:09:14 PST
mgoetz just highlighted that I have blindly converted everything to DirectConnection. With some luck I'm not reverting bug #25556. Once we are confident that it is not crashing we should remove the signal and do a direct function call again.
Markus Goetz
Comment 4 2009-12-15 00:08:10 PST
This patch depends on a bugfix inside Qt 4.6. It should hit qt.gitorious.org in the next days. http://pastebin.ca/1714463
Holger Freyther
Comment 5 2009-12-15 01:10:45 PST
Created attachment 44852 [details] [Qt] Followup for direct signals and slots connections in QNetworkReplyHandler
WebKit Review Bot
Comment 6 2009-12-15 01:14:07 PST
style-queue ran check-webkit-style on attachment 44852 [details] without any errors.
Simon Hausmann
Comment 7 2009-12-15 07:08:18 PST
Comment on attachment 44852 [details] [Qt] Followup for direct signals and slots connections in QNetworkReplyHandler Good idea and good save :), r=me
Holger Freyther
Comment 8 2009-12-15 08:20:02 PST
Landed in r52153.
Note You need to log in before you can comment on or make changes to this bug.