Bug 33606

Summary: style checker needs to know about GObject-specific requirements inside WebCore/bindings/gobject/
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch for landing none

Gustavo Noronha (kov)
Reported 2010-01-13 09:54:37 PST
Xan is working on finally pushing the DOM bindings patch forward again, and we will end up having the WebCore/bindings/gobject/ directory, which will contain many GObject definitions. GObject definitions require a couple of functions to initialize the class structure, and the instance structure, and they need to use lowercased, underscore-separated names (to respect the names given by a define). Here's an example: https://bugs.webkit.org/show_bug.cgi?id=33590#c11
Attachments
Patch (2.48 KB, patch)
2010-01-17 15:52 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.47 KB, patch)
2010-01-18 01:30 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-01-17 15:52:31 PST
Created attachment 46764 [details] Patch
WebKit Commit Bot
Comment 2 2010-01-17 19:36:41 PST
Comment on attachment 46764 [details] Patch Rejecting patch 46764 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Darin Adler', '--force']" exit_code: 1 patching file WebKitTools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKitTools/Scripts/webkitpy/style/cpp_style.py Hunk #1 FAILED at 2491. 1 out of 1 hunk FAILED -- saving rejects to file WebKitTools/Scripts/webkitpy/style/cpp_style.py.rej patching file WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py Hunk #1 succeeded at 3570 with fuzz 2 (offset 23 lines). Full output: http://webkit-commit-queue.appspot.com/results/195516
Adam Barth
Comment 3 2010-01-18 01:30:01 PST
Created attachment 46799 [details] Patch for landing
Adam Barth
Comment 4 2010-01-18 02:13:47 PST
Comment on attachment 46799 [details] Patch for landing Clearing flags on attachment: 46799 Committed r53399: <http://trac.webkit.org/changeset/53399>
Adam Barth
Comment 5 2010-01-18 02:13:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.