Bug 34275

Summary: MathML CSS update to remove line-height
Product: WebKit Reporter: Alex Milowski <alex>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 3251    
Attachments:
Description Flags
MathML CSS patch none

Alex Milowski
Reported 2010-01-28 10:45:38 PST
Created attachment 47631 [details] MathML CSS patch This patch removed the unnecessary line-height settings and updates the existing tests.
Attachments
MathML CSS patch (37.11 KB, patch)
2010-01-28 10:45 PST, Alex Milowski 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-01-28 11:59:39 PST
Comment on attachment 47631 [details] MathML CSS patch Your ChangeLog does not explain why it's unecessary. Or how it positively effects the layout test results?
Alex Milowski
Comment 2 2010-01-28 12:04:40 PST
(In reply to comment #1) > (From update of attachment 47631 [details]) > Your ChangeLog does not explain why it's unecessary. Or how it positively > effects the layout test results? At this point, this updated CSS or the previous one will not make much of a difference in terms of the line-height setting. The line-height settings are from experiments from earlier code. The negatively affect other rendering objects that are in other patches. They only make minor adjustments to the current tests that are almost imperceptible. This is basically a cleanup of the CSS in preparation for more rendering objects and tests in the future.
Eric Seidel (no email)
Comment 3 2010-01-28 12:15:16 PST
Comment on attachment 47631 [details] MathML CSS patch OK. Should say more of that in the ChangeLog in the future. :) But this is OK. Thanks for the explanation.
WebKit Commit Bot
Comment 4 2010-01-28 16:57:55 PST
Comment on attachment 47631 [details] MathML CSS patch Clearing flags on attachment: 47631 Committed r54029: <http://trac.webkit.org/changeset/54029>
WebKit Commit Bot
Comment 5 2010-01-28 16:58:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.