Bug 35001

Summary: websocket/tests/cookies/httponly-cookie.pl fails every time under run-chromium-webkit-tests
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Fumitoshi Ukai <ukai>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, ojan, ukai, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 34984    
Attachments:
Description Flags
Patch eric: review+

Eric Seidel (no email)
Reported 2010-02-16 15:06:48 PST
websocket/tests/cookies/httponly-cookie.pl fails every time under run-chromium-webkit-tests The WebSocket server that run-chromium-webkit-tests is running seems to be just returning the contents of the .pl file instead of actually executing the perl.
Attachments
Patch (1.21 KB, patch)
2010-02-16 17:56 PST, Fumitoshi Ukai 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2010-02-16 15:56:12 PST
We probably need to merge http://codereview.chromium.org/565027 upstream (the fix for https://bugs.webkit.org/show_bug.cgi?id=34289).
Fumitoshi Ukai
Comment 2 2010-02-16 17:56:33 PST
Created attachment 48852 [details] Patch
Eric Seidel (no email)
Comment 3 2010-02-16 18:15:05 PST
Comment on attachment 48852 [details] Patch That seems like the wrong path.
Fumitoshi Ukai
Comment 4 2010-02-16 18:23:23 PST
(In reply to comment #3) > (From update of attachment 48852 [details]) > That seems like the wrong path. What do you mean? A path for -x is the relative path to document root, and this path is the same used in WebKitTools/Scripts/run-webkit-websocketserver.
Fumitoshi Ukai
Comment 5 2010-02-16 18:33:30 PST
(In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 48852 [details] [details]) > > That seems like the wrong path. > > What do you mean? > A path for -x is the relative path to document root, and this path is the same > used in WebKitTools/Scripts/run-webkit-websocketserver. Note that current chromium would fail this test. need http://codereview.chromium.org/601077 to pass the test.
Eric Seidel (no email)
Comment 6 2010-02-17 11:49:28 PST
Comment on attachment 48852 [details] Patch LGTM.
Eric Seidel (no email)
Comment 7 2010-02-17 14:23:50 PST
Attachment 48852 [details] was posted by a committer and has review+, assigning to Fumitoshi Ukai for commit.
Fumitoshi Ukai
Comment 8 2010-02-17 18:19:53 PST
Committed r54920: <http://trac.webkit.org/changeset/54920>
Note You need to log in before you can comment on or make changes to this bug.