Bug 36369

Summary: [Qt] Maemo5 theme - <select multiple> custom rendering
Product: WebKit Reporter: Luiz Agostini <luiz>
Component: PlatformAssignee: Luiz Agostini <luiz>
Status: CLOSED FIXED    
Severity: Normal CC: hausmann, kenneth
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Bug Depends on:    
Bug Blocks: 36372    
Attachments:
Description Flags
patch 1 commit-queue: commit-queue-

Luiz Agostini
Reported 2010-03-19 08:10:27 PDT
As Maemo5 will use popups for all <select> elements so <select multiple>elements will be rendered as combobox. <select multiple> rendering must then be somehow different from other comboboxes rendering to give the user a hint that this is a 'multiple' combo.
Attachments
patch 1 (7.13 KB, patch)
2010-04-01 13:30 PDT, Luiz Agostini 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tor Arne Vestbø
Comment 1 2010-03-22 06:37:01 PDT
Bugs relating to the Qt port of WebKit should have the Qt keyword. See http://trac.webkit.org/wiki/QtWebKitBugs
Luiz Agostini
Comment 2 2010-04-01 13:30:53 PDT
Created attachment 52328 [details] patch 1
Kenneth Rohde Christiansen
Comment 3 2010-04-01 13:47:32 PDT
Comment on attachment 52328 [details] patch 1 r=me, in the future please make more collaborated ChangeLog entries. It would be nice if you could attach a screenshot to the bug report, showing the before and after.
WebKit Commit Bot
Comment 4 2010-04-01 17:34:05 PDT
Comment on attachment 52328 [details] patch 1 Rejecting patch 52328 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12608 test cases. fast/loader/stateobjects/replacestate-then-pushstate.html -> failed Exiting early after 1 failures. 7840 tests run. 137.58s total testing time 7839 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 4 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/1619163
Eric Seidel (no email)
Comment 5 2010-04-01 18:20:06 PDT
Comment on attachment 52328 [details] patch 1 You hit bug 36647.
WebKit Commit Bot
Comment 6 2010-04-01 22:34:03 PDT
Comment on attachment 52328 [details] patch 1 Clearing flags on attachment: 52328 Committed r56970: <http://trac.webkit.org/changeset/56970>
WebKit Commit Bot
Comment 7 2010-04-01 22:45:53 PDT
Comment on attachment 52328 [details] patch 1 Rejecting patch 52328 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--force']" exit_code: 1 Last 500 characters of output: letions(-) ------------------------------------------------------------------- patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/platform/qt/Maemo5Webstyle.cpp Hunk #1 succeeded at 22 with fuzz 2 (offset 2 lines). Hunk #2 FAILED at 157. Hunk #3 FAILED at 249. 2 out of 3 hunks FAILED -- saving rejects to file WebCore/platform/qt/Maemo5Webstyle.cpp.rej patching file WebCore/platform/qt/Maemo5Webstyle.h Hunk #1 succeeded at 42 with fuzz 2 (offset 5 lines). Full output: http://webkit-commit-queue.appspot.com/results/1612163
Luiz Agostini
Comment 8 2010-04-05 07:16:57 PDT
patch is landed.
Luiz Agostini
Comment 9 2010-04-05 07:33:09 PDT
landed in r56970
Simon Hausmann
Comment 10 2010-04-06 03:13:34 PDT
Revision r56970 cherry-picked into qtwebkit-2.0 with commit 61e4fea52f0a4d2ef4db188043a03e071f18446e
Note You need to log in before you can comment on or make changes to this bug.