Bug 36760
| Summary: | check-webkit-style shouldn't complain about namespace indents in forward declarations | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | cjerdonek, darin, hamaji, levin |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Adam Barth
--- Comment #70 from Darin Adler <darin@apple.com> 2010-03-29 09:07:38 PST ---
(In reply to comment #69)
> > > Done, but now style checking script barks at me.
> >
> > Bug in the script.
>
> Is it?
>
> +namespace JSC {
> +
> + class JSGlobalData;
> + class MarkStack;
> +
> +}
>
> versus Rule #3 <http://webkit.org/coding/coding-style.html>?
There's nothing specific in the coding style document to make it clear that
indenting is desirable in forward declarations as opposed to the actual code
defined in a header.
But there should be.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Levin
It sounds like the desired rule is that namespaces which only have fwd declarations (class/struct) should be indented. (Or is it all fwd declarations should be indented?)
I'm pretty sure it is the former.
Original bug with the comment: https://bugs.webkit.org/show_bug.cgi?id=33696
Tony Gentilcore
*** Bug 47755 has been marked as a duplicate of this bug. ***