Bug 36911

Summary: Add webkit-patch command to crawl buildbot history and find when tests started to fail
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, abecsi, aroben, jchaffraix, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 37063    
Attachments:
Description Flags
Patch
none
First Try
none
Patch abarth: review+

Eric Seidel (no email)
Reported 2010-03-31 17:50:55 PDT
Add webkit-patch command to crawl buildbot history and find when tests started to fail
Attachments
Patch (13.63 KB, patch)
2010-03-31 17:56 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
First Try (16.80 KB, patch)
2010-04-06 20:26 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (16.88 KB, patch)
2010-04-06 23:29 PDT, Eric Seidel (no email) 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-03-31 17:56:34 PDT
Created attachment 52228 [details] Patch
Adam Barth
Comment 2 2010-03-31 18:06:46 PDT
+ raise "Unhandled title: %s" % str(table_title) We should only be raising Exception objects. Better to raise an Exception(). + def _print_blame_information_for_commit(tool, commit_info): This should be in a base class? Maybe on CommitInfo? Having a random global function seems strange. + class FailureReason(AbstractDeclarativeCommand): This class is kind of lame. It makes it really hard to re-use this logic or to test it. Maybe we need a FailureWalker class?
Eric Seidel (no email)
Comment 3 2010-04-06 20:26:26 PDT
Created attachment 52696 [details] First Try
Eric Seidel (no email)
Comment 4 2010-04-06 20:27:04 PDT
Updated it so it applies to TOT. Haven't bothered to abstract out the build-walker stuff.
Eric Seidel (no email)
Comment 5 2010-04-06 23:29:00 PDT
Created attachment 52704 [details] Patch
Adam Barth
Comment 6 2010-04-06 23:37:46 PDT
Comment on attachment 52704 [details] Patch Ok. Let's take this as a starting point. As you noted in the other bug, there's a lot of overlap with the algorithm the sheriff uses to track recent regressions. This code looks like it understands more cases (e.g., >= 20 failures). We should find a way to unify and abstract out the different pieces,but I don't want to hold this patch hostage any longer.
Eric Seidel (no email)
Comment 7 2010-04-06 23:41:18 PDT
Committed r57195: <http://trac.webkit.org/changeset/57195>
Note You need to log in before you can comment on or make changes to this bug.