Bug 37320

Summary: [Qt] tst_QWebFrame::popupFocus() fails
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: Tools / TestsAssignee: Yi Shen <max.hong.shen>
Status: CLOSED FIXED    
Severity: Blocker CC: commit-queue, cshu, kenneth, luiz
Priority: P1 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Bug Depends on:    
Bug Blocks: 35784    
Attachments:
Description Flags
proposal patch
kenneth: review-
patch
kenneth: review-
patch none

Simon Hausmann
Reported 2010-04-09 02:57:08 PDT
PASS : tst_QWebFrame::initTestCase() FAIL! : tst_QWebFrame::popupFocus() 'combo != 0' returned FALSE. () Loc: [/home/shausman/src/webkit/trunk/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(2520)] PASS : tst_QWebFrame::cleanupTestCase() Reproducible on Linux/X11. It does not appear to be timing related, it fails consistenly for me.
Attachments
proposal patch (1.30 KB, patch)
2010-04-09 11:58 PDT, Yi Shen 		kenneth: review-
DetailsFormatted DiffDiff
patch (1.44 KB, patch)
2010-04-09 12:53 PDT, Yi Shen 		kenneth: review-
DetailsFormatted DiffDiff
patch (1.45 KB, patch)
2010-04-09 13:28 PDT, Yi Shen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yi Shen
Comment 1 2010-04-09 11:58:20 PDT
Created attachment 52972 [details] proposal patch The class WebCore::QWebPopup has been removed, so the test cases need to be updated also.
Luiz Agostini
Comment 2 2010-04-09 12:28:40 PDT
I can verify that this is the right fix. But you should elaborate more on what you are doing and how you fixed it in change log.
Kenneth Rohde Christiansen
Comment 3 2010-04-09 12:30:15 PDT
(In reply to comment #2) > I can verify that this is the right fix. But you should elaborate more on what > you are doing and how you fixed it in change log. I agree, the ChangeLog entry doesn't fulfill the requirements of the projects, r- for that reason. Please provide a new patch with a better description and I will review it ASAP! Thanks :-)
Yi Shen
Comment 4 2010-04-09 12:53:45 PDT
Created attachment 52980 [details] patch updated the description in the changelog
Kenneth Rohde Christiansen
Comment 5 2010-04-09 13:19:29 PDT
Comment on attachment 52980 [details] patch > + > + The QWebPopup class has been moved & renamed, so tst_QWebFrame::popupFocus() should use the class name "QComboBox", rather than "WebCore::QWebPopup" to find the popup menu. > + :-( Please keep the changelog at max 80-100 char per line as everyone else. sorry
Yi Shen
Comment 6 2010-04-09 13:28:39 PDT
Created attachment 52982 [details] patch
Yi Shen
Comment 7 2010-04-09 13:29:22 PDT
It's my bad :) Thanks for the reviewing.
WebKit Commit Bot
Comment 8 2010-04-09 17:51:35 PDT
Comment on attachment 52982 [details] patch Clearing flags on attachment: 52982 Committed r57388: <http://trac.webkit.org/changeset/57388>
WebKit Commit Bot
Comment 9 2010-04-09 17:51:41 PDT
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 10 2010-04-12 07:11:53 PDT
Revision r57388 cherry-picked into qtwebkit-2.0 with commit 862268aeb7150d3795d05bfc05f661bb5c598a27
Note You need to log in before you can comment on or make changes to this bug.