Bug 37587

Summary: new-run-webkit-tests: try to detect alternate apache path
Product: WebKit Reporter: Tor Arne Vestbø <vestbo>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 37765    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Tor Arne Vestbø
Reported 2010-04-14 11:04:08 PDT
new-run-webkit-tests: try to detect alternate apache path
Attachments
Patch (1.68 KB, patch)
2010-04-14 11:06 PDT, Tor Arne Vestbø 		no flags
DetailsFormatted DiffDiff
Patch (2.27 KB, patch)
2010-04-14 13:03 PDT, Tor Arne Vestbø 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tor Arne Vestbø
Comment 1 2010-04-14 11:06:13 PDT
Created attachment 53345 [details] Patch
Eric Seidel (no email)
Comment 2 2010-04-14 11:38:38 PDT
Comment on attachment 53345 [details] Patch Seems reasonable. We should add a comment about why we have to detect multiple apaches. Also, it seems like we might want to cache this information so we're not stating the file repeatedly?
Tor Arne Vestbø
Comment 3 2010-04-14 13:03:34 PDT
Created attachment 53356 [details] Patch
Eric Seidel (no email)
Comment 4 2010-04-14 13:16:41 PDT
Comment on attachment 53356 [details] Patch Fantastic!
WebKit Commit Bot
Comment 5 2010-04-14 19:48:59 PDT
Comment on attachment 53356 [details] Patch Rejecting patch 53356 from commit-queue. Unexpected failure when landing patch! Please file a bug against webkit-patch. Failed to run "['WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--test', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', '53356', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Last 500 characters of output: ', 'commit', '--all', '-F', '-'], input=message) File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/common/system/executive.py", line 85, in run_command return Executive().run_command(*args, **kwargs) File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/common/system/executive.py", line 186, in run_command string_to_communicate = str(input) UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in position 26: ordinal not in range(128)
Eric Seidel (no email)
Comment 6 2010-04-14 20:13:22 PDT
I think I know how to fix this now. We can use codec.encode(input, "latin1") (or some variant) to encode the utf-8 down to latin1 w/o exception before passing to to the subprocess?
Eric Seidel (no email)
Comment 7 2010-04-14 20:23:43 PDT
Actually, I mispoke. We likely want to encode the python unicode object into utf8 to feed to our subproccess.
Eric Seidel (no email)
Comment 8 2010-04-19 12:24:05 PDT
Sorry. If bug 37765 isn't landed today, I'll land this change by hand.
Eric Seidel (no email)
Comment 9 2010-04-20 12:57:51 PDT
Comment on attachment 53356 [details] Patch Sorry again for the trouble.
Eric Seidel (no email)
Comment 10 2010-04-21 03:48:51 PDT
Comment on attachment 53356 [details] Patch The fix for bug 37765 was rolled out. So this will fail to land. Hopefully I'll reland the fix tomorrow at which point I'll cq+ this again.
Eric Seidel (no email)
Comment 11 2010-04-21 03:57:46 PDT
Comment on attachment 53356 [details] Patch Clearing flags on attachment: 53356 Committed r57964: <http://trac.webkit.org/changeset/57964>
Eric Seidel (no email)
Comment 12 2010-04-21 03:57:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.