Bug 37934

Summary: [Qt] QtLauncher: make FPS measurement accurate
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Normal CC: commit-queue, hausmann, loulockman8, webkit.review.bot
Priority: P2 Keywords: Performance, Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 35784    
Attachments:
Description Flags
correct fps measurement
none
fix some style issues
none
Fixed namings and added comments none

Noam Rosenthal
Reported 2010-04-21 10:40:28 PDT
currently FPS measurements in Qt-launcher gives bogus results, as it measures paint events which are different than frames. we want a more accurate measurement.
Attachments
correct fps measurement (8.22 KB, patch)
2010-04-21 10:53 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
fix some style issues (8.21 KB, patch)
2010-04-21 11:07 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Fixed namings and added comments (8.39 KB, patch)
2010-04-21 13:53 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2010-04-21 10:53:09 PDT
Created attachment 53969 [details] correct fps measurement
WebKit Review Bot
Comment 2 2010-04-21 11:01:20 PDT
Attachment 53969 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/QtLauncher/fpsmeasure.cpp:28: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKitTools/QtLauncher/fpsmeasure.cpp:30: Alphabetical sorting problem. [build/include_order] [4] WebKitTools/QtLauncher/fpsmeasure.cpp:42: Missing space after , [whitespace/comma] [3] WebKitTools/QtLauncher/fpsmeasure.h:28: #ifndef header guard has wrong style, please use: fpsmeasure_h [build/header_guard] [5] WebKitTools/QtLauncher/fpsmeasure.h:33: Alphabetical sorting problem. [build/include_order] [4] WebKitTools/QtLauncher/fpsmeasure.h:36: This { should be at the end of the previous line [whitespace/braces] [4] WebKitTools/QtLauncher/fpsmeasure.h:40: Use 0 instead of NULL. [readability/null] [5] Total errors found: 7 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Noam Rosenthal
Comment 3 2010-04-21 11:07:24 PDT
Created attachment 53972 [details] fix some style issues one of the style issues cannot be fixed - fixed all the rest.
WebKit Review Bot
Comment 4 2010-04-21 11:12:53 PDT
Attachment 53972 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/QtLauncher/fpsmeasure.cpp:28: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Noam Rosenthal
Comment 5 2010-04-21 13:53:16 PDT
Created attachment 53988 [details] Fixed namings and added comments
WebKit Review Bot
Comment 6 2010-04-21 13:55:21 PDT
Attachment 53988 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/QtLauncher/fpstimer.cpp:28: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKitTools/QtLauncher/fpstimer.h:28: #ifndef header guard has wrong style, please use: fpstimer_h [build/header_guard] [5] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 7 2010-04-21 20:32:02 PDT
Comment on attachment 53988 [details] Fixed namings and added comments Clearing flags on attachment: 53988 Committed r58047: <http://trac.webkit.org/changeset/58047>
WebKit Commit Bot
Comment 8 2010-04-21 20:32:08 PDT
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 9 2010-04-26 03:44:32 PDT
Revision r58047 cherry-picked into qtwebkit-2.0 with commit d566cf9e73b32ce286f580de1f19627f38353afb
Note You need to log in before you can comment on or make changes to this bug.