Bug 40127

Summary: [Qt] Don't send notifications event after the page was navigated away
Product: WebKit Reporter: Yael <yael>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 39995    
Attachments:
Description Flags
Patch. laszlo.gombos: review+, laszlo.gombos: commit-queue+

Yael
Reported 2010-06-03 09:41:42 PDT
Notification objects can outlive the page they are in. If the ScriptExecutionContext that created the notification was destroyed, don't invoke "display" or "close" events on the notification object. When running inside DRT, also don't log after the ScriptExecutionContext was destroyed. I actually don't understand why this is not causing failures on the build bot.
Attachments
Patch. (1.92 KB, patch)
2010-06-03 09:47 PDT, Yael 		laszlo.gombos: review+
laszlo.gombos: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yael
Comment 1 2010-06-03 09:47:15 PDT
Created attachment 57783 [details] Patch.
Laszlo Gombos
Comment 2 2010-06-03 10:12:08 PDT
Comment on attachment 57783 [details] Patch. Looks good to me. r+.
Yael
Comment 3 2010-06-03 10:36:10 PDT
Committed r60630: <http://trac.webkit.org/changeset/60630>
Simon Hausmann
Comment 4 2010-08-03 08:33:18 PDT
Revision r60630 cherry-picked into qtwebkit-2.1 with commit 7c263035b4010a8c7cf057eb7d2ba0fdd336929d
Note You need to log in before you can comment on or make changes to this bug.