Bug 40673
| Summary: | offsetForPositionForComplexText() truncates float -> int on several platforms | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> |
| Component: | Text | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | d-r, mrobinson |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | All | ||
| Bug Depends on: | 40665 | ||
| Bug Blocks: | |||
Nikolas Zimmermann
When bug 40665 lands, offsetForPositionForComplexText() no longer takes an 'int' parameter for the position, but a float. This is only relevant for SVG text, which supports subpixel positioning, and only for complex text.
Qt and Mac handle the float parameter properly, Win/Gtk etc not. That should be fixed, but has low importance.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Dominik Röttsches (drott)
Nikolas, I'll close this as duplicate. For GTK & EFL this is fixed in bug 92376, landed as r124111. HarfBuzzShaper::offsetForPosition now takes a float argument and does the computation with this value without breaking it down or rounding it.
Please reopen if you think this is not completely fixed.
*** This bug has been marked as a duplicate of bug 92376 ***
Dominik Röttsches (drott)
(In reply to comment #1)
> For GTK & EFL...
What i meant: For Harfbuzz-NG ports.