Bug 41255

Summary: Add more use of reflection, remove unused functions
Product: WebKit Reporter: Darin Adler <darin>
Component: DOMAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 41077    
Attachments:
Description Flags
Patch sam: review+

Darin Adler
Reported 2010-06-26 11:47:32 PDT
Add more use of reflection, remove unused functions
Attachments
Patch (87.89 KB, patch)
2010-06-26 12:32 PDT, Darin Adler 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2010-06-26 12:32:46 PDT
Created attachment 59843 [details] Patch
WebKit Review Bot
Comment 2 2010-06-26 13:04:19 PDT
Attachment 59843 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/3305742
WebKit Review Bot
Comment 3 2010-06-26 13:27:52 PDT
Attachment 59843 [details] did not build on win: Build output: http://webkit-commit-queue.appspot.com/results/3321834
Darin Adler
Comment 4 2010-06-26 13:43:27 PDT
Committed r61959: <http://trac.webkit.org/changeset/61959>
WebKit Review Bot
Comment 5 2010-06-26 13:49:48 PDT
http://trac.webkit.org/changeset/61959 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, and Qt Linux ARMv7 Release
Darin Adler
Comment 6 2010-06-26 13:52:20 PDT
http://trac.webkit.org/changeset/61960 fixes a stray character and should fix at least some platforms. Waiting to see if bots indicate any other breakage.
Darin Adler
Comment 7 2010-06-26 13:55:09 PDT
http://trac.webkit.org/changeset/61961 is an attempt to fix Qt by adding back a function it uses
Darin Adler
Comment 8 2010-06-26 14:13:49 PDT
http://trac.webkit.org/changeset/61963 is an attempt to fix Chromium by adding back functions it uses
Note You need to log in before you can comment on or make changes to this bug.