Bug 42698

Summary: WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, kling, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch
none
patch2
none
patch3 none

Sam Weinig
Reported 2010-07-20 15:17:30 PDT
WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
Attachments
patch (12.58 KB, patch)
2011-09-29 10:52 PDT, qi 		no flags
DetailsFormatted DiffDiff
patch2 (12.57 KB, patch)
2011-09-29 11:07 PDT, qi 		no flags
DetailsFormatted DiffDiff
patch3 (12.66 KB, patch)
2011-09-30 07:08 PDT, qi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-07-20 15:30:58 PDT
<rdar://problem/8213838>
qi
Comment 2 2011-09-29 10:52:41 PDT
Created attachment 109175 [details] patch 1. Implemented layoutTestController.setAppCacheMaximumSize. 2. To keep the test result consistent, implemented layoutTestController.clearApplicationCache and call clearApplicationCache() when layoutTest startup.
WebKit Review Bot
Comment 3 2011-09-29 10:55:27 PDT
Attachment 109175 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h:130: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h:128: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
qi
Comment 4 2011-09-29 11:07:02 PDT
Created attachment 109178 [details] patch2 Fix style issue.
Andreas Kling
Comment 5 2011-09-29 13:19:04 PDT
Comment on attachment 109178 [details] patch2 View in context: https://bugs.webkit.org/attachment.cgi?id=109178&action=review > Source/WebKit2/WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:104 > + cacheStorage().setMaximumSize(size); Shouldn't this be guarded by a termination disabler?
qi
Comment 6 2011-09-30 07:08:32 PDT
Created attachment 109296 [details] patch3 Based on Kling's comments make a change.
Andreas Kling
Comment 7 2011-09-30 09:21:11 PDT
Comment on attachment 109296 [details] patch3 LGTM.
WebKit Review Bot
Comment 8 2011-09-30 10:25:22 PDT
Comment on attachment 109296 [details] patch3 Clearing flags on attachment: 109296 Committed r96405: <http://trac.webkit.org/changeset/96405>
WebKit Review Bot
Comment 9 2011-09-30 10:25:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.