Bug 43905

Summary: [Qt] animations tests fails which uses suspend/resume
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Alexis Menard (darktears) <menard>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, eric, joybro201, menard, oliver, ossy
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 48161, 49182    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2010-08-12 04:39:06 PDT
animations/suspend-resume-animation.html introduced in http://trac.webkit.org/changeset/65107 and it fails on the Qt bot: --- /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/layout-test-results/animations/suspend-resume-animation-expected.txt 2010-08-12 04:13:57.692174443 -0700 +++ /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/layout-test-results/animations/suspend-resume-animation-actual.txt 2010-08-12 04:13:57.692174443 -0700 @@ -2,5 +2,5 @@ PASS - "webkitTransform" property for "box" element at 0.6s saw something close to: 1,0,0,1,200,0 PASS - "webkitTransform" property for "box" element at 0.9s saw something close to: 1,0,0,1,200,0 -PASS - "webkitTransform" property for "box" element at 1.5s saw something close to: 1,0,0,1,400,0 +FAIL - "webkitTransform" property for "box" element at 1.5s expected: 1,0,0,1,400,0 but saw: matrix(1, 0, 0, 1, 212, 0)
Attachments
Patch (2.07 KB, patch)
2012-01-20 06:36 PST, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2010-08-12 05:08:10 PDT
Skipped by http://trac.webkit.org/changeset/65236 until fix.
Chris Marrin
Comment 2 2010-11-05 15:12:26 PDT
From the failure, it looks like suspend is working, but resume is not. A new test is failing which also uses suspend/resume: LayoutTests/animations/stop-animation-on-suspend.html
Csaba Osztrogonác
Comment 3 2010-11-05 15:35:07 PDT
(In reply to comment #2) > From the failure, it looks like suspend is working, but resume is not. > > A new test is failing which also uses suspend/resume: > > LayoutTests/animations/stop-animation-on-suspend.html stop-animation-on-suspend.html introduced in http://trac.webkit.org/changeset/71424 pretty diffs: http://build.webkit.org/results/Qt%20Linux%20Release/r71452%20(23266)/animations/stop-animation-on-suspend-pretty-diff.html http://build.webkit.org/results/Qt%20Linux%20Release/r71452%20(23266)/animations/suspend-resume-animation-events-pretty-diff.html I skipped them: http://trac.webkit.org/changeset/71453
Young Han Lee
Comment 4 2011-06-05 10:06:31 PDT
(In reply to comment #3) > (In reply to comment #2) > > From the failure, it looks like suspend is working, but resume is not. > > > > A new test is failing which also uses suspend/resume: > > > > LayoutTests/animations/stop-animation-on-suspend.html > > stop-animation-on-suspend.html introduced in http://trac.webkit.org/changeset/71424 > > pretty diffs: > http://build.webkit.org/results/Qt%20Linux%20Release/r71452%20(23266)/animations/stop-animation-on-suspend-pretty-diff.html > http://build.webkit.org/results/Qt%20Linux%20Release/r71452%20(23266)/animations/suspend-resume-animation-events-pretty-diff.html > > I skipped them: http://trac.webkit.org/changeset/71453 animations/suspend-resume-animation.html animations/suspend-resume-animation-events.html animations/stop-animation-on-suspend.html In r88132, webkit-qt is passing the above tests you skipped. Don't these tests have to be unskipped? :)
Alexis Menard (darktears)
Comment 5 2012-01-20 06:36:44 PST
Created attachment 123305 [details] Patch
Csaba Osztrogonác
Comment 6 2012-01-20 06:53:53 PST
Comment on attachment 123305 [details] Patch r=me and landed in http://trac.webkit.org/changeset/105511
Note You need to log in before you can comment on or make changes to this bug.