Bug 43923

Summary: HTMLMediaElement::prepareForLoad should cancel current plug-in proxy media player
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, ddkilzer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 51249    
Attachments:
Description Flags
proposed patch ddkilzer: review+

Eric Carlson
Reported 2010-08-12 10:53:06 PDT
When building WebKit with PLUGIN_PROXY_FOR_VIDEO, the MediaPlayer is not destroyed and recreated when loading a new movie to avoid the expensive plug-in setup and handshake each time a movie is loaded. Because the current movie may still be loading, the plug-in proxy method cancelLoad should be called to give it a signal that a new movie will be loading.
Attachments
proposed patch (1.25 KB, patch)
2010-08-12 11:33 PDT, Eric Carlson 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2010-08-12 11:33:40 PDT
Created attachment 64242 [details] proposed patch
David Kilzer (:ddkilzer)
Comment 2 2010-08-13 04:12:34 PDT
Comment on attachment 64242 [details] proposed patch r=me
Eric Carlson
Comment 3 2010-08-13 08:53:14 PDT
trac.webkit.org/changeset/65324
Ademar Reis
Comment 4 2011-01-24 12:19:13 PST
Revision r65324 cherry-picked into qtwebkit-2.2 with commit 6a0dc57 <http://gitorious.org/webkit/qtwebkit/commit/6a0dc57>
Note You need to log in before you can comment on or make changes to this bug.