Bug 44674

Summary: [Qt] tst_QWebFrame::popupFocus() hardcode the element position
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: Tools / TestsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, commit-queue
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 44675    
Attachments:
Description Flags
Fix the issue on Meego none

Benjamin Poulain
Reported 2010-08-26 04:14:36 PDT
The test tst_QWebFrame::popupFocus() assume the position (25, 25) is inside the combo box. This is not true depending on the style, and the test fails on Meego.
Attachments
Fix the issue on Meego (1.43 KB, patch)
2010-08-26 04:18 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2010-08-26 04:18:29 PDT
Created attachment 65544 [details] Fix the issue on Meego This patch dynamically find the position of the combo element instead of hardcoding a position to click.
WebKit Commit Bot
Comment 2 2010-08-26 05:07:05 PDT
Comment on attachment 65544 [details] Fix the issue on Meego Clearing flags on attachment: 65544 Committed r66096: <http://trac.webkit.org/changeset/66096>
WebKit Commit Bot
Comment 3 2010-08-26 05:07:11 PDT
All reviewed patches have been landed. Closing bug.
Ademar Reis
Comment 4 2010-08-26 08:48:36 PDT
Revision r66096 cherry-picked into qtwebkit-2.1 with commit 5019f1f94fcf1b367ce7396acf36890a9f91c5b0
Note You need to log in before you can comment on or make changes to this bug.