Bug 4540

Summary: event handlers for all custom events called when any custom event is set
Product: WebKit Reporter: Darin Adler <darin>
Component: DOMAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cdumez
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 4565    
Attachments:
Description Flags
patch to use AtomicString instead of an integer as an event ID mjs: review+

Darin Adler
Reported 2005-08-20 13:59:48 PDT
One of the W3C DOM tests exposes the fact that we don't handle custom events propertly. All custom events share a single list of event listeners.
Attachments
patch to use AtomicString instead of an integer as an event ID (177.30 KB, patch)
2005-08-20 18:57 PDT, Darin Adler 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2005-08-20 16:20:04 PDT
Maciej mentioned that Anders may already be working on this, which is too bad, since I have a patch ready!
Darin Adler
Comment 2 2005-08-20 18:57:33 PDT
Created attachment 3484 [details] patch to use AtomicString instead of an integer as an event ID I've done some testing on this, but it still needs its own test for the layout-tests directory and some performance testing too.
Darin Adler
Comment 3 2005-08-21 17:36:58 PDT
This is part of the reason that the dispatchEvent12 test in the W3C DOM Level 2 Events suite is failing, but there's another reason, described in bug 4570.
Maciej Stachowiak
Comment 4 2005-08-30 02:21:20 PDT
Great patch! r=me
Lucas Forschler
Comment 5 2019-02-06 09:02:55 PST
Mass moving XML DOM bugs to the "DOM" Component.
Note You need to log in before you can comment on or make changes to this bug.