Bug 46177

Summary: Make FilterEffects independent of SVG
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit-ews, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 68469, 26389    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Dirk Schulze
Reported 2010-09-21 04:50:54 PDT
Make FilterEffects independent of SVG
Attachments
Patch (301.21 KB, patch)
2010-09-21 04:58 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Patch (301.69 KB, patch)
2010-09-21 05:22 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Patch (337.28 KB, patch)
2010-09-21 05:42 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Patch (341.99 KB, patch)
2010-09-21 07:33 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Patch (341.98 KB, patch)
2010-09-21 23:47 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2010-09-21 04:58:25 PDT
Created attachment 68220 [details] Patch
Dirk Schulze
Comment 2 2010-09-21 04:59:08 PDT
(In reply to comment #1) > Created an attachment (id=68220) [details] > Patch Just Mac is missing, since I can't update Xcode from here.
Nikolas Zimmermann
Comment 3 2010-09-21 05:13:06 PDT
(In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=68220) [details] [details] > > Patch > > Just Mac is missing, since I can't update Xcode from here. Isn't it possible to manually move them, by just editing the file?; The UUID stays the same, you should just have to reorder them.
Early Warning System Bot
Comment 4 2010-09-21 05:15:54 PDT
Attachment 68220 [details] did not build on qt: Build output: http://queues.webkit.org/results/3999077
Dirk Schulze
Comment 5 2010-09-21 05:22:59 PDT
Created attachment 68222 [details] Patch
Eric Seidel (no email)
Comment 6 2010-09-21 05:32:47 PDT
Attachment 68220 [details] did not build on mac: Build output: http://queues.webkit.org/results/4049096
Dirk Schulze
Comment 7 2010-09-21 05:42:12 PDT
Created attachment 68224 [details] Patch
Dirk Schulze
Comment 8 2010-09-21 05:42:49 PDT
(In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > Created an attachment (id=68220) [details] [details] [details] > > > Patch > > > > Just Mac is missing, since I can't update Xcode from here. > > Isn't it possible to manually move them, by just editing the file?; > The UUID stays the same, you should just have to reorder them. Tried it with the last patch. Let's see if I got it to work.
Eric Seidel (no email)
Comment 9 2010-09-21 05:43:19 PDT
Attachment 68222 [details] did not build on mac: Build output: http://queues.webkit.org/results/4026090
Eric Seidel (no email)
Comment 10 2010-09-21 05:57:38 PDT
Attachment 68224 [details] did not build on mac: Build output: http://queues.webkit.org/results/4098015
Dirk Schulze
Comment 11 2010-09-21 07:33:03 PDT
Created attachment 68239 [details] Patch
Dirk Schulze
Comment 12 2010-09-21 07:38:59 PDT
Modified the project file with Xcode this time. Hopefully it builds now. Didn't test it on my local machine.
Dirk Schulze
Comment 13 2010-09-21 22:20:49 PDT
Not sure why the ews bot for win has problems. I updated to trunk and had no problems applying this patch.
Dirk Schulze
Comment 14 2010-09-21 23:46:16 PDT
Uploading the same patch again to restart Win EWS.
Dirk Schulze
Comment 15 2010-09-21 23:47:20 PDT
Created attachment 68341 [details] Patch
Nikolas Zimmermann
Comment 16 2010-09-22 00:12:52 PDT
Comment on attachment 68341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68341&action=review > WebCore/ChangeLog:16 > + * WebCore.vcproj/WebCore.vcproj: WebCore.xcodeproj not listed here. Even if we don't know if win builds, EWS is taking just too long. Just try landing.
Dirk Schulze
Comment 17 2010-09-22 00:42:37 PDT
Committed r68022: <http://trac.webkit.org/changeset/68022>
Dirk Schulze
Comment 18 2010-10-04 01:35:59 PDT
Comment on attachment 68341 [details] Patch Already committed. Clearing r-flag.
Note You need to log in before you can comment on or make changes to this bug.