Bug 46196

Summary: Add marginBefore/After/Start/End accessors to RenderBoxModelObject and subclasses
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 46123    
Attachments:
Description Flags
Patch
none
Patch mitz: review+

Dave Hyatt
Reported 2010-09-21 09:55:12 PDT
Add marginBefore/After/Start/End accessors to RenderBoxModelObject and subclasses.
Attachments
Patch (7.56 KB, patch)
2010-09-21 09:59 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (7.56 KB, patch)
2010-09-21 10:01 PDT, Dave Hyatt 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-09-21 09:59:58 PDT
Created attachment 68252 [details] Patch
Dave Hyatt
Comment 2 2010-09-21 10:01:25 PDT
Created attachment 68253 [details] Patch
mitz
Comment 3 2010-09-21 10:05:04 PDT
Comment on attachment 68253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68253&action=review > WebCore/rendering/RenderInline.h:44 > + virtual int marginTop() const; > + virtual int marginBottom() const; Any reason why these need to be public now (or, for that matter, any of the new methods)?
Dave Hyatt
Comment 4 2010-09-21 10:49:38 PDT
Fixed in r67964.
Note You need to log in before you can comment on or make changes to this bug.