Bug 46248

Summary: [Qt] Fix bugs when building WebKit with Qt 4.7.1
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, cmarcelo, hausmann, kling, laszlo.gombos, ossy
Priority: P2 Keywords: Qt, QtTriaged, Regression
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 46249, 46250, 46251, 47073, 50144, 50145, 50146, 50147, 51819    
Bug Blocks:    
Attachments:
Description Flags
migrating to Qt 4.7.1
none
proposed patch for QtWebKit-2.1.x branch
none
proposed patch for QtWebKit-2.1 and 2.1.x branches none

Csaba Osztrogonác
Reported 2010-09-22 01:52:08 PDT
Nokia released Qt 4.7.0, but now ~140 layout tests fail when building WebKit trunk with Qt 4.7.0. (Qt buildbots use Qt 4.6.2 on build.webkit.org now.) "x86-32 Linux Qt-4.7.0 Release" buildbot here: http://webkit.sed.hu/buildbot/waterfall Most of them (~120-130) only need a rebaseline, but there are ~10-20 real bug should be fixed. We are going to set Qt buildbots on build.webkit.org to use Qt 4.7.0 after this meta bug fixed.
Attachments
migrating to Qt 4.7.1 (613.82 KB, patch)
2010-11-29 07:15 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
proposed patch for QtWebKit-2.1.x branch (578.48 KB, patch)
2011-03-23 08:11 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
proposed patch for QtWebKit-2.1 and 2.1.x branches (37.14 KB, patch)
2011-03-23 19:55 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2010-10-29 09:30:14 PDT
*** Bug 48633 has been marked as a duplicate of this bug. ***
Csaba Osztrogonác
Comment 2 2010-11-29 07:15:20 PST
Created attachment 75024 [details] migrating to Qt 4.7.1 I think it's time to migrating Qt 4.7.1. The proposed patch: - add failing tests to the Skipped list - remove passing tests from the Skipped list - update expected files related to the migration (4.6.3 -> 4.7.1)
Andreas Kling
Comment 3 2010-11-30 00:06:59 PST
Comment on attachment 75024 [details] migrating to Qt 4.7.1 Awesome, go for it :)
Csaba Osztrogonác
Comment 4 2010-11-30 02:55:01 PST
Comment on attachment 75024 [details] migrating to Qt 4.7.1 Landed in http://trac.webkit.org/changeset/72896 Leave the bug open until depending bugs are fixed.
Csaba Osztrogonác
Comment 5 2011-03-23 08:11:58 PDT
Created attachment 86619 [details] proposed patch for QtWebKit-2.1.x branch I merged http://trac.webkit.org/changeset/72896 to QtWebKit-2.1.x branch without Skipped list modifications. ( I had to remove ~10 expected update from the original patch, because they are already updated in the branch.) Laszlo, Andreas, rs=you? to push it to the QtWebKit-2.1.x and 2.1 branches?
Andreas Kling
Comment 6 2011-03-23 08:13:12 PDT
rs=me
Caio Marcelo de Oliveira Filho
Comment 7 2011-03-23 08:59:49 PDT
Cherry-picked into qtwebkit-2.1 branch with commit 3f3d191ac9dca758cdca75b77f0337f4e5b1e37f <http://gitorious.org/webkit/qtwebkit/commit/3f3d191ac9dca758cdca75b77f0337f4e5b1e37f>
Caio Marcelo de Oliveira Filho
Comment 8 2011-03-23 09:00:16 PDT
Also merged to qtwebkit-2.1.x branch.
Csaba Osztrogonác
Comment 9 2011-03-23 19:55:38 PDT
Created attachment 86736 [details] proposed patch for QtWebKit-2.1 and 2.1.x branches Merging http://trac.webkit.org/changeset/72896 to QtWebKit-2.1 QtWebKit-2.1.x branches - step 2. - I added tests to the Skipped list, which passed with Qt 4.6, but fail with Qt 4.7.2 . - I removed tests from the Skipped list, which failed with Qt 4.6, but pass now. rs=?
Andreas Kling
Comment 10 2011-03-24 05:16:02 PDT
(In reply to comment #9) > Created an attachment (id=86736) [details] > proposed patch for QtWebKit-2.1 and 2.1.x branches > > Merging http://trac.webkit.org/changeset/72896 to QtWebKit-2.1 QtWebKit-2.1.x branches - step 2. > > - I added tests to the Skipped list, which passed with Qt 4.6, but fail with Qt 4.7.2 . > - I removed tests from the Skipped list, which failed with Qt 4.6, but pass now. > > rs=? rs=me, yo!
Caio Marcelo de Oliveira Filho
Comment 11 2011-03-24 05:47:41 PDT
Cherry-picked into qtwebkit-2.1 branch with commit f3c5fd7b5e2bb27edd8e0afc2b16b69a7514c301 <http://gitorious.org/webkit/qtwebkit/commit/f3c5fd7b5e2bb27edd8e0afc2b16b69a7514c301> And also merged to qtwebkit-2.1.x branch.
Simon Hausmann
Comment 12 2012-07-19 07:23:28 PDT
Closing this bug as it seems work is completed and we don't support Qt 4.7 anymore anyway :)
Csaba Osztrogonác
Comment 13 2012-07-21 13:15:28 PDT
(In reply to comment #12) > Closing this bug as it seems work is completed and we don't support Qt 4.7 anymore anyway :) I don't think if it is completed, because bugs on depends on list are still valid with Qt 4.8 and Qt 5.0.
Simon Hausmann
Comment 14 2012-07-23 00:23:22 PDT
True, those bugs are still open. But they are not necessarily directly related to Qt 4.7 I think.
Note You need to log in before you can comment on or make changes to this bug.