Bug 46454

Summary: Renames of a bunch of calcXXX methods.
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 46123    
Attachments:
Description Flags
Patch mjs: review+

Dave Hyatt
Reported 2010-09-24 00:14:09 PDT
Just doing a bunch of renames together. Will list them all. calcReplacedWidth -> computeReplacedWidth calcHorizontalMargins -> computeInlineDirectionMargins calcVerticalMargins -> computeBlockDirectionMargins calcWidthUsing -> computeLogicalWidthUsing calcHeightUsing -> computeLogicalHeightUsing calcReplacedHeight/HeightUsing -> computeReplacedHeight/HeightUsing calcAbsoluteHorizontalValues -> computePositionedLogicalWidthUsing calcAbsoluteVerticalValues -> computePositionedLogicalHeightUsing calcAbsoluteHorizontal -> computePositionedLogicalWIdth calcAbsoluteVertical -> computePositionedLogicalHeight calcAbsoluteHorizontalReplaced -> computePositionedLogicalWidthReplaced calcAbsoluteVerticalReplaced -> computePositionedLogicalHeightReplaced calcBorderBoxWidth/Height -> computeBorderBoxLogicalWidth/LogicalHeight calcContentBoxWidth/Height -> computeContentBoxLogicalWidth/LogicalHeight shouldCalculateSizeAsReplaced -> shouldComputeSizeAsReplaced calcPercentageHeight -> computePercentageLogicalHeight
Attachments
Patch (74.27 KB, patch)
2010-09-24 00:19 PDT, Dave Hyatt 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-09-24 00:19:36 PDT
Created attachment 68658 [details] Patch
Maciej Stachowiak
Comment 2 2010-09-24 00:23:06 PDT
Comment on attachment 68658 [details] Patch r=me
Dave Hyatt
Comment 3 2010-09-24 00:26:42 PDT
Fixed in r68239.
Note You need to log in before you can comment on or make changes to this bug.