Bug 47797

Summary: Clean up of iframe scrollbar mode code
Product: WebKit Reporter: Mike Lawther <mikelawther>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, hyatt, manyoso, ossy, tonikitoo, webkit.review.bot, yael
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Mike Lawther
Reported 2010-10-17 23:00:07 PDT
Followup to comments in https://bugs.webkit.org/show_bug.cgi?id=29240#c19 "Some comments... seems like it would be cleaner to turn off scrollbars early and bail in the helper function rather than doing it at the very end. That way you're not flipping stuff on and off. In order to do that, though, you need to pull the setChildNeedsLayout/setNeedsLayout calls (which should never have been put in this code in the first place) out of the helper function and back into the main layout method. None of this is minus-worthy, though, so could be fixed in a followup."
Attachments
Patch (5.26 KB, patch)
2010-10-19 21:10 PDT, Mike Lawther 		no flags
DetailsFormatted DiffDiff
Patch (4.76 KB, patch)
2010-11-18 16:20 PST, Mike Lawther 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike Lawther
Comment 1 2010-10-19 21:10:10 PDT
Created attachment 71244 [details] Patch
Mike Lawther
Comment 2 2010-10-19 21:50:44 PDT
Hi Hyatt - can you please take a look at this cleanup?
Mike Lawther
Comment 3 2010-11-18 16:20:02 PST
Created attachment 74314 [details] Patch
Mike Lawther
Comment 4 2010-11-18 16:21:59 PST
Made sure patch still applies to current tree.
Dave Hyatt
Comment 5 2010-12-01 15:45:09 PST
Comment on attachment 74314 [details] Patch r=me
WebKit Commit Bot
Comment 6 2010-12-02 02:12:45 PST
Comment on attachment 74314 [details] Patch Clearing flags on attachment: 74314 Committed r73117: <http://trac.webkit.org/changeset/73117>
WebKit Commit Bot
Comment 7 2010-12-02 02:12:51 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 8 2010-12-02 02:27:53 PST
http://trac.webkit.org/changeset/73117 might have broken Qt Linux Release minimal
Csaba Osztrogonác
Comment 9 2010-12-02 03:05:11 PST
(In reply to comment #8) > http://trac.webkit.org/changeset/73117 might have broken Qt Linux Release minimal Buildfix landed in http://trac.webkit.org/changeset/73120
Note You need to log in before you can comment on or make changes to this bug.