Bug 48664

Summary: Make repaint invalidation work with flipped blocks ("rl" and "bt")
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 46123    
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+

Dave Hyatt
Reported 2010-10-29 12:35:11 PDT
Make repaint invalidation work with flipped blocks ("rl" and "bt")
Attachments
Patch (58.09 KB, patch)
2010-11-11 13:46 PST, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (59.40 KB, patch)
2010-11-11 13:48 PST, Dave Hyatt 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-11-11 13:46:42 PST
Created attachment 73652 [details] Patch
Dave Hyatt
Comment 2 2010-11-11 13:48:22 PST
Created attachment 73653 [details] Patch
Simon Fraser (smfr)
Comment 3 2010-11-11 14:01:28 PST
Comment on attachment 73653 [details] Patch r=me but I'd like to see more comments (as discussed on irc).
Dave Hyatt
Comment 4 2010-11-11 14:10:59 PST
(In reply to comment #3) > (From update of attachment 73653 [details]) > r=me but I'd like to see more comments (as discussed on irc). I added some comments to the headers and then wrote a novella in RenderBox::computeRectForRepaint.
Dave Hyatt
Comment 5 2010-11-11 14:17:58 PST
Fixed in r71851.
WebKit Review Bot
Comment 6 2010-11-11 14:55:24 PST
http://trac.webkit.org/changeset/71851 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: fast/table/colspanMinWidth-vertical.html
Note You need to log in before you can comment on or make changes to this bug.