Bug 49567

Summary: nrwt multiprocessing - remove port-specific child process restrictions
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: abarth, eric, hayato, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 49566    
Attachments:
Description Flags
Patch ojan: review-

Dirk Pranke
Reported 2010-11-15 15:21:39 PST
need to remove the platform-specific restrictions on the default # of child processes when we fix the threading/multiprocessing issues.
Attachments
Patch (2.65 KB, patch)
2010-11-15 15:27 PST, Dirk Pranke 		ojan: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2010-11-15 15:27:10 PST
Created attachment 73936 [details] Patch
Dirk Pranke
Comment 2 2010-11-15 15:28:55 PST
Note that this should actually be the *last* of the MP (multiprocess) patches to land, after all the code is working and tested. The GPU tests (in chromium_gpu.py) will still default to 1, since there's GPU-related stability with parallel testing.
Ojan Vafai
Comment 3 2010-11-16 06:25:12 PST
Comment on attachment 73936 [details] Patch Marking r- for now just because it's blocked on other patches. Maybe r? this patch once it's actually possible to commit it? The patch looks fine, although I expect the assumption is that another patch removes the default_child_processes call somewhere.
Dirk Pranke
Comment 4 2010-11-16 11:39:01 PST
(In reply to comment #0) > need to remove the platform-specific restrictions on the default # of child processes when we fix the threading/multiprocessing issues. r- for now is fine. We still need the call, though, which will fall through to the base class implementation, which gives us the # of CPUs.
Dirk Pranke
Comment 5 2010-12-02 02:54:48 PST
closing as wontfix - 50381 is now the way to do this. *** This bug has been marked as a duplicate of bug 50381 ***
Note You need to log in before you can comment on or make changes to this bug.