Bug 49638

Summary:

[chromium] REGRESSION(72141): Chromium fails acid3 on windows and linux

Product:

WebKit

Reporter:

James Robinson <jamesr>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, agl, dglazkov, eric, evan, fishd, hyatt, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	fishd: review+

James Robinson

Reported 2010-11-16 18:46:02 PST

http://trac.webkit.org/changeset/72141 fixed a pair of bugs in font-size and line height handling and requires that the default minimum font size be changed from 1 to 0. The patch at http://codereview.chromium.org/4954002/ changes the default minimum values (except for Chromium DumpRenderTree, which needs http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/chromium/WebPreferences.cpp#L68 to be edited) but we still render the 100/100 text at slightly the wrong offset in Chromium linux. I haven't tested Chromium mac/windows yet. CC'ing a bunch of font people randomly to see if anyone knows what's up. We might just be clamping 0 to a nonzero value somewhere badly.

Attachments
Patch (4.13 KB, patch) 2010-11-17 13:11 PST, James Robinson	no flags	Details Formatted Diff Diff
Patch (5.30 KB, patch) 2010-11-18 11:34 PST, James Robinson	fishd: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.