Bug 50732

Summary:

Allow disabling of font smoothing in compositing layers to be overridden by style

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Layout and Rendering

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, dglazkov, eric, mitz, simon.fraser, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

50733

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	mitz: review+

Simon Fraser (smfr)

Reported 2010-12-08 20:36:13 PST

It should be possible for a web developer to override the non-smoothed fonts in compositing layers via CSS, which they might want to do if they know the layer background is opaque.

Attachments
Patch (9.81 KB, patch) 2010-12-13 18:17 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (9.82 KB, patch) 2010-12-13 18:37 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (9.82 KB, patch) 2010-12-14 11:35 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (9.92 KB, patch) 2010-12-14 15:15 PST, Simon Fraser (smfr)	mitz: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2010-12-08 20:38:22 PST

<rdar://problem/8747953>

Simon Fraser (smfr)

Comment 2 2010-12-13 18:17:37 PST

Created attachment 76479 [details] Patch

WebKit Review Bot

Comment 3 2010-12-13 18:31:56 PST

Attachment 76479 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6960105

Simon Fraser (smfr)

Comment 4 2010-12-13 18:37:07 PST

Created attachment 76480 [details] Patch

Eric Seidel (no email)

Comment 5 2010-12-13 20:52:18 PST

Attachment 76480 [details] did not build on mac: Build output: http://queues.webkit.org/results/7048009

Eric Seidel (no email)

Comment 6 2010-12-13 21:12:11 PST

Attachment 76480 [details] did not build on mac: Build output: http://queues.webkit.org/results/6901116

Eric Seidel (no email)

Comment 7 2010-12-14 01:01:22 PST

Attachment 76480 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7023110

Simon Fraser (smfr)

Comment 8 2010-12-14 11:35:50 PST

Created attachment 76551 [details] Patch

Eric Seidel (no email)

Comment 9 2010-12-14 12:05:34 PST

Attachment 76551 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6944123

Eric Seidel (no email)

Comment 10 2010-12-14 13:19:24 PST

Attachment 76551 [details] did not build on mac: Build output: http://queues.webkit.org/results/6921149

Simon Fraser (smfr)

Comment 11 2010-12-14 15:15:52 PST

Created attachment 76579 [details] Patch

Simon Fraser (smfr)

Comment 12 2010-12-15 13:29:01 PST

Dan has a valuable point here. This patch (and existing webkit, actually), allows CSS to turn on font smoothing when the user may have disabled it system-wide via the System Preferences. However, that issue is not new with this patch. We should address is separately.

mitz

Comment 13 2010-12-15 13:48:25 PST

Comment on attachment 76579 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76579&action=review Why isn’t the Font code using the new GraphicsContext methods? I choose to r- what I don’t understand :) > WebCore/ChangeLog:39 > +2010-12-13 Simon Fraser <simon.fraser@apple.com> > + > + GraphicsContextPrivate.h was removed. Nuke it from the project. > + > + * WebCore.xcodeproj/project.pbxproj: > + Old change log entry

Simon Fraser (smfr)

Comment 14 2010-12-15 13:48:52 PST

(In reply to comment #12) > Dan has a valuable point here. This patch (and existing webkit, actually), allows CSS to turn on font smoothing when the user may have disabled it system-wide via the System Preferences. Testing shows that this is not actually true, before or after this patch. The System Preference setting trumps all.

Simon Fraser (smfr)

Comment 15 2010-12-15 15:37:06 PST

http://trac.webkit.org/changeset/74151

Note You need to log in before you can comment on or make changes to this bug.