Bug 51018

Summary: Rebaseline: leading and trailing EOL must occur consistently in expectation files
Product: WebKit Reporter: Cosmin Truta <ctruta>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, commit-queue, eric, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 36983    
Attachments:
Description Flags
Rebaseline
eric: review+, commit-queue: commit-queue-
Rebaseline none

Cosmin Truta
Reported 2010-12-14 01:14:16 PST
Opening this bug in preparation for landing the patch to bug 36983. There are lots of expectation files involved, and I hope I haven't missed or mistyped any. Only Chromium (mac/linux/win) is affected, because, so far, only Chromium uses new-run-webkit-tests.
Attachments
Rebaseline (261.83 KB, patch)
2010-12-14 01:42 PST, Cosmin Truta 		eric: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Rebaseline (261.88 KB, patch)
2010-12-14 17:52 PST, Cosmin Truta 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Cosmin Truta
Comment 1 2010-12-14 01:42:48 PST
Created attachment 76516 [details] Rebaseline This is in preparation for the submission of the patch to bug 36983. I hope I haven't missed anything.
Eric Seidel (no email)
Comment 2 2010-12-14 13:09:19 PST
Comment on attachment 76516 [details] Rebaseline LGTM.
Eric Seidel (no email)
Comment 3 2010-12-14 13:09:35 PST
I'm very glad to see the tools converging.
WebKit Commit Bot
Comment 4 2010-12-14 13:41:41 PST
The commit-queue encountered the following flaky tests while processing attachment 76516 [details]: inspector/extensions-api.html bug 51053 (author: caseq@chromium.org) http/tests/security/cross-origin-xsl-BLOCKED.html bug 51054 (author: abarth@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2010-12-14 14:28:39 PST
The commit-queue encountered the following flaky tests while processing attachment 76516 [details]: http/tests/security/cross-origin-xsl-BLOCKED.html bug 51054 (author: abarth@webkit.org) fast/events/platform-wheelevent-in-scrolling-div.html bug 51056 (author: aestes@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2010-12-14 16:30:43 PST
Comment on attachment 76516 [details] Rebaseline Rejecting attachment 76516 [details] from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2 Last 500 characters of output: ........... http/tests/multipart ..... http/tests/navigation ............................................................................................ http/tests/plugins ........ http/tests/security ................................................. http/tests/security/cross-origin-xsl-BLOCKED.html -> failed Exiting early after 1 failures. 21602 tests run. 491.60s total testing time 21601 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 13 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/7110004
Cosmin Truta
Comment 7 2010-12-14 17:52:50 PST
Created attachment 76605 [details] Rebaseline Resubmitting, with cross-origin-xsl-BLOCKED-expected.txt modified for Chromium only. Apparently, the chromium test runs leave an extra blank line at the end, compared to all the other non-chromium webkit runs.
Eric Seidel (no email)
Comment 8 2010-12-14 18:02:53 PST
Comment on attachment 76605 [details] Rebaseline Thanks for doing this. If this one fails, you might consider landing this is pieces. I'm happy to rs=me any of these.
Cosmin Truta
Comment 9 2010-12-14 18:04:43 PST
Thank you for assisting me with this, Eric. It's been a headache so far, but I'm sure it's well worth it.
WebKit Commit Bot
Comment 10 2010-12-14 20:20:15 PST
Comment on attachment 76605 [details] Rebaseline Clearing flags on attachment: 76605 Committed r74097: <http://trac.webkit.org/changeset/74097>
WebKit Commit Bot
Comment 11 2010-12-14 20:20:22 PST
All reviewed patches have been landed. Closing bug.
Brian Weinstein
Comment 12 2010-12-15 12:23:50 PST
This broke plugins/document-open.html on Windows. Failure: http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r74131%20(7469)/plugins/document-open-pretty-diff.html
Cosmin Truta
Comment 13 2010-12-15 15:35:34 PST
Opened bug 51147 to add some missing expectation files.
Note You need to log in before you can comment on or make changes to this bug.