Bug 51046

Summary: Expose AccessibilityObject::url() to Chromium
Product: WebKit Reporter: Chris Guillory <ctguil>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, fishd, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Patch
fishd: review-, fishd: commit-queue-
Patch none

Chris Guillory
Reported 2010-12-14 10:43:49 PST
During a chromium code review we determined that we needed access to the url of link accessibility objects. http://codereview.chromium.org/5751002/
Attachments
Proposed Patch (1.75 KB, patch)
2010-12-14 11:59 PST, Chris Guillory 		fishd: review-
fishd: commit-queue-
DetailsFormatted DiffDiff
Patch (2.02 KB, patch)
2010-12-14 23:18 PST, Chris Guillory 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Guillory
Comment 1 2010-12-14 11:59:30 PST
Created attachment 76552 [details] Proposed Patch
Chris Guillory
Comment 2 2010-12-14 12:00:16 PST
WebKit API change.
Darin Fisher (:fishd, Google)
Comment 3 2010-12-14 20:49:36 PST
Comment on attachment 76552 [details] Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76552&action=review > WebKit/chromium/public/WebAccessibilityObject.h:113 > + WEBKIT_API WebString url() const; nit: we ordinarily expose urls using WebURL. it looks like m_private->url() is a KURL object. (KURL can be implicitly converted to WebURL.)
Chris Guillory
Comment 4 2010-12-14 23:18:07 PST
Created attachment 76633 [details] Patch Returning as WebURL.
WebKit Commit Bot
Comment 5 2010-12-15 16:45:08 PST
The commit-queue encountered the following flaky tests while processing attachment 76633 [details]: animations/combo-transform-translate+scale.html bug 50958 (authors: cmarrin@apple.com, darin@apple.com, ojan@chromium.org, and pol@apple.com) fast/preloader/script.html bug 50879 (author: abarth@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2010-12-15 19:32:00 PST
Comment on attachment 76633 [details] Patch Clearing flags on attachment: 76633 Committed r74171: <http://trac.webkit.org/changeset/74171>
WebKit Commit Bot
Comment 7 2010-12-15 19:32:06 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 8 2010-12-16 15:37:53 PST
http://trac.webkit.org/changeset/74171 might have broken Leopard Intel Debug (Tests)
Note You need to log in before you can comment on or make changes to this bug.