Bug 51236

Summary: Make java/argument-to-object-type.html use shouldBeEqualToString to make it easier to debug
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED INVALID    
Severity: Normal CC: abarth, ap, commit-queue, ggaren, mrowe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 51102    
Attachments:
Description Flags
Patch abarth: review+, commit-queue: commit-queue-

Eric Seidel (no email)
Reported 2010-12-17 00:40:11 PST
Make java/argument-to-object-type.html use shouldBeEqualToString to make it easier to debug
Attachments
Patch (1.74 KB, patch)
2010-12-17 00:41 PST, Eric Seidel (no email) 		abarth: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-12-17 00:41:53 PST
Created attachment 76854 [details] Patch
Eric Seidel (no email)
Comment 2 2010-12-17 00:42:34 PST
I've not actually run this (since I don't have a copy of webkit built), but the cq will build and run the tests for me. This should make it easier to solve bug 51102.
WebKit Commit Bot
Comment 3 2010-12-17 02:56:51 PST
The commit-queue encountered the following flaky tests while processing attachment 76854 [details]: fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org) java/argument-to-object-type.html bug 51102 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2010-12-17 03:23:06 PST
Comment on attachment 76854 [details] Patch Rejecting attachment 76854 [details] from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2 Last 500 characters of output: ......................................................................................................................................................................... inspector ................................................................................. java . java/argument-to-object-type.html -> failed Exiting early after 1 failures. 17897 tests run. 292.72s total testing time 17896 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 8 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/7290011
Eric Seidel (no email)
Comment 5 2010-12-17 03:52:37 PST
The failure can be seen here: https://bugs.webkit.org/attachment.cgi?id=76861 I guess that's why we didn't shouldBeEqualToSTring.
Alexey Proskuryakov
Comment 6 2010-12-17 12:04:01 PST
Eric, has this been rolled out?
Eric Seidel (no email)
Comment 7 2010-12-17 12:30:10 PST
It was never rolled in. :)
Alexey Proskuryakov
Comment 8 2010-12-17 12:43:42 PST
Oh, ok. I was looking at <https://bug-51102-attachments.webkit.org/attachment.cgi?id=76861>, and didn't realize that it was from a failed attempt to commit this change.
Eric Seidel (no email)
Comment 9 2010-12-17 12:53:15 PST
Yeah. It's slightly concerning that the queue thought that the failed attempt was a flaky test. Calls our flaky test detection into question. But as far as I know this was never committed. Looks like our flaky test detection code will report a constant failure as a flaky test if another test happens to flake at the same time: http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/tool/bot/commitqueuetask.py#L171 Notice how if first_failing_tests is non-empty, we run the tests again, if a different set of tests fail, we report them all as flaky (which is wrong!). I'll file a separate bug to fix.
Eric Seidel (no email)
Comment 10 2010-12-17 12:57:54 PST
Filed bug 51272 about the flaky test detection code being wrong.
Note You need to log in before you can comment on or make changes to this bug.