Bug 51237

Summary: [chromium] canvas.toDataURL("image/jpeg") should composite onto black
Product: WebKit Reporter: noel gordon <noel.gordon>
Component: CanvasAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, hbono, levin, mdelaney7, mikelawther, oliver, senorblanco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Bug Depends on:    
Bug Blocks: 67402    
Attachments:
Description Flags
patch
none
patch
none
patch update changelog description
none
patch update test_expectations.txt none

noel gordon
Reported 2010-12-17 00:50:33 PST
[chromium] canvas.toDataURL("image/jpeg") composite onto black
Attachments
patch (2.82 KB, patch)
2010-12-17 00:59 PST, noel gordon 		no flags
DetailsFormatted DiffDiff
patch (3.01 KB, patch)
2010-12-17 01:32 PST, noel gordon 		no flags
DetailsFormatted DiffDiff
patch update changelog description (3.03 KB, patch)
2010-12-19 17:14 PST, noel gordon 		no flags
DetailsFormatted DiffDiff
patch update test_expectations.txt (4.51 KB, patch)
2010-12-19 22:45 PST, noel gordon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
noel gordon
Comment 1 2010-12-17 00:59:51 PST
Created attachment 76855 [details] patch
Eric Seidel (no email)
Comment 2 2010-12-17 01:02:13 PST
Comment on attachment 76855 [details] patch Doesn't this need to include pixel test updates and or test_expectations.txt updates?
Eric Seidel (no email)
Comment 3 2010-12-17 01:02:30 PST
Oliver knows way more about canvas than I do.
noel gordon
Comment 4 2010-12-17 01:08:59 PST
> Oliver knows way more about canvas than I do. No worries, that's why I added Stephen. Bear with me a moment while I update another patch.
noel gordon
Comment 5 2010-12-17 01:32:42 PST
Created attachment 76858 [details] patch
noel gordon
Comment 6 2010-12-19 17:14:10 PST
Created attachment 76964 [details] patch update changelog description
noel gordon
Comment 7 2010-12-19 22:43:54 PST
(In reply to comment #2) > Doesn't this need to include pixel test updates and or test_expectations.txt updates? yes, added test_expectations.txt update.
noel gordon
Comment 8 2010-12-19 22:45:20 PST
Created attachment 76977 [details] patch update test_expectations.txt
James Robinson
Comment 9 2010-12-30 20:36:52 PST
Comment on attachment 76977 [details] patch update test_expectations.txt Looks good to me.
WebKit Commit Bot
Comment 10 2011-01-11 04:46:24 PST
Comment on attachment 76977 [details] patch update test_expectations.txt Clearing flags on attachment: 76977 Committed r75488: <http://trac.webkit.org/changeset/75488>
WebKit Commit Bot
Comment 11 2011-01-11 04:46:30 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 12 2011-01-11 17:23:08 PST
resolved http://www.w3.org/Bugs/Public/show_bug.cgi?id=11431 WONTFIX
Note You need to log in before you can comment on or make changes to this bug.