Bug 51898

Summary: PingLoader should be able to send cookies
Product: WebKit Reporter: Nate Chapin <japhet>
Component: WebCore Misc.Assignee: Nate Chapin <japhet>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
fishd: review+, commit-queue: commit-queue-
Fix line endings in ping-cookie-expected.txt commit-queue: commit-queue-

Nate Chapin
Reported 2011-01-04 14:25:09 PST
I appear to have forgotten to override ResourceHandleClient::shouldUseCredentialStorage() when writing PingLoader, so it never sends cookies. This is in violation of http://www.whatwg.org/specs/web-apps/current-work/multipage/links.html#hyperlink-auditing. I suppose it's open to debate whether image loads in unload handlers should send cookies, but it seems like it would make sense to send them if the image load would have sent cookies if it hadn't gone through PingLoader.
Attachments
patch (6.31 KB, patch)
2011-01-04 14:38 PST, Nate Chapin 		fishd: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Fix line endings in ping-cookie-expected.txt (6.30 KB, patch)
2011-01-06 15:59 PST, Nate Chapin 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nate Chapin
Comment 1 2011-01-04 14:38:14 PST
Created attachment 77934 [details] patch
WebKit Commit Bot
Comment 2 2011-01-05 17:21:41 PST
Comment on attachment 77934 [details] patch Rejecting attachment 77934 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2 Last 500 characters of output: http/tests/messaging .. http/tests/mime ........ http/tests/misc ...................................................................................................... http/tests/multipart ..... http/tests/navigation ............................................. http/tests/navigation/ping-cookie.html -> failed Exiting early after 1 failures. 21608 tests run. 565.62s total testing time 21607 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 13 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/7237445
Nate Chapin
Comment 3 2011-01-06 15:59:50 PST
Created attachment 78183 [details] Fix line endings in ping-cookie-expected.txt Sigh.
WebKit Commit Bot
Comment 4 2011-01-06 17:52:08 PST
The commit-queue encountered the following flaky tests while processing attachment 78183 [details]: media/invalid-media-url-crash.html bug 51138 (author: inferno@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2011-01-06 17:53:27 PST
Comment on attachment 78183 [details] Fix line endings in ping-cookie-expected.txt Rejecting attachment 78183 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 78183]" exit_code: 1 Last 500 characters of output: st/multicol/float-multicol-expected.png A LayoutTests/platform/mac-leopard/fast/multicol/client-rects-expected.png A LayoutTests/platform/mac-leopard/fast/repaint/overflow-scroll-body-appear-expected.png A LayoutTests/platform/mac-leopard/fast/repaint/overflow-scroll-body-appear-expected.checksum M LayoutTests/ChangeLog r75215 = 25d07aa449496542cfe8b05b8a0f2d4bef93a36f (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/trunk. Full output: http://queues.webkit.org/results/7376012
Nate Chapin
Comment 6 2011-01-07 12:22:10 PST
Landed manually: http://trac.webkit.org/changeset/75261
Note You need to log in before you can comment on or make changes to this bug.