Bug 52208

Summary: Align import/export directives in WebKit2
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, sam, s.mathur
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch
none
Remove indentation none

Laszlo Gombos
Reported 2011-01-11 06:30:03 PST
r75404 (http://trac.webkit.org/changeset/75404) introduced a set of fixes to WebKit2 import/export macros. These macros should be align across the entire project project.
Attachments
proposed patch (3.32 KB, patch)
2011-01-11 06:40 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
Remove indentation (3.56 KB, patch)
2011-01-14 07:37 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2011-01-11 06:40:05 PST
Created attachment 78523 [details] proposed patch Another option would be to have a shared header file under wtf to make sure these rules are aligned.
Eric Seidel (no email)
Comment 2 2011-01-11 11:47:29 PST
I'm not sure your #define indent matches webkit style.
Laszlo Gombos
Comment 3 2011-01-14 07:37:06 PST
Created attachment 78940 [details] Remove indentation
WebKit Commit Bot
Comment 4 2011-01-14 09:46:59 PST
Comment on attachment 78940 [details] Remove indentation Rejecting attachment 78940 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'build-..." exit_code: 2 Last 500 characters of output: ................................ fast/images/load-img-with-empty-src.html -> timed out Sampling process 18778 for 10 seconds with 10 milliseconds of run time between samples Sampling completed, processing symbols... Sample analysis of process 18778 written to file /Users/chrome-bot/Library/Logs/DumpRenderTree/HangReport.txt Exiting early after 1 failures. 8872 tests run. 258.75s total testing time 8871 test cases (99%) succeeded 1 test case (<1%) timed out 6 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/7557041
WebKit Commit Bot
Comment 5 2011-01-14 09:56:41 PST
The commit-queue encountered the following flaky tests while processing attachment 78940 [details]: http/tests/media/video-load-twice.html bug 51304 (authors: eric.carlson@apple.com and hclam@google.com) The commit-queue is continuing to process your patch.
Laszlo Gombos
Comment 6 2011-01-14 11:01:33 PST
Comment on attachment 78940 [details] Remove indentation Try again...
WebKit Commit Bot
Comment 7 2011-01-14 11:51:04 PST
Comment on attachment 78940 [details] Remove indentation Clearing flags on attachment: 78940 Committed r75806: <http://trac.webkit.org/changeset/75806>
WebKit Commit Bot
Comment 8 2011-01-14 11:51:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.