Bug 53566

Summary: [v8] Increase V8 native->js recursion limit to match document.write() recursion limit
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ager, annacc, barraclough, commit-queue, dglazkov, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

James Robinson
Reported 2011-02-01 18:15:00 PST
[v8] Increase V8 native->js recursion limit to match document.write() recursion limit
Attachments
Patch (2.68 KB, patch)
2011-02-01 18:16 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2011-02-01 18:16:23 PST
Created attachment 80869 [details] Patch
James Robinson
Comment 2 2011-02-01 18:18:07 PST
This passes the test. I would prefer to match JSC exactly here but I can't find any equivalent limit in the JSC bindings, at least at a quick glance. Adding some people who might be familiar with the JSC bindings to see if they know of such a limit.
Adam Barth
Comment 3 2011-02-01 19:55:09 PST
Comment on attachment 80869 [details] Patch In crbug, you said JSC's limit was 256. I'll leave it up to your judgement as to which number to use. (I'd probably go with 22 absent other information.)
Gavin Barraclough
Comment 4 2011-02-01 20:04:23 PST
JSC should soon be removing its arbitrary limit in favour of checking available machine stack, so matching the current limit is probably less important. (FWIW 22 sounds like a perfectly reasonable limit to me too!)
James Robinson
Comment 5 2011-02-01 21:13:13 PST
Comment on attachment 80869 [details] Patch Let's go with 22 and see what happens!
WebKit Commit Bot
Comment 6 2011-02-01 23:03:03 PST
Comment on attachment 80869 [details] Patch Clearing flags on attachment: 80869 Committed r77364: <http://trac.webkit.org/changeset/77364>
WebKit Commit Bot
Comment 7 2011-02-01 23:03:09 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 8 2011-02-01 23:35:40 PST
http://trac.webkit.org/changeset/77364 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: http/tests/xmlhttprequest/cross-origin-no-authorization.html
Anna Cavender
Comment 9 2011-04-01 13:24:22 PDT
*** Bug 53557 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.