Bug 54196

Summary: Add some fields to ResourceRequest and ResourceResponse
Product: WebKit Reporter: Bill Budge <bbudge>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 53925    
Attachments:
Description Flags
Proposed patch
none
Proposed patch
none
Proposed Patch none

Bill Budge
Reported 2011-02-10 05:37:01 PST
Created attachment 81958 [details] Proposed patch Some fields are needed on ResourceRequest and ResourceResponse so that WebURLResponse and WebURLRequest data is passed down to the client supplied URLLoader. This is in preparation for a later patch to add CORS support to AssociatedURLLoader.
Attachments
Proposed patch (6.39 KB, patch)
2011-02-10 05:37 PST, Bill Budge 		no flags
DetailsFormatted DiffDiff
Proposed patch (6.38 KB, patch)
2011-02-10 05:45 PST, Bill Budge 		no flags
DetailsFormatted DiffDiff
Proposed Patch (6.38 KB, patch)
2011-02-10 09:52 PST, Bill Budge 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2011-02-10 05:40:06 PST
Attachment 81958 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/network/chromium/ResourceResponse.h:101: Tab found; better to use spaces [whitespace/tab] [1] Source/WebCore/platform/network/chromium/ResourceResponse.h:156: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Bill Budge
Comment 2 2011-02-10 05:45:38 PST
Created attachment 81960 [details] Proposed patch Found some style errors
David Levin
Comment 3 2011-02-10 07:36:19 PST
Comment on attachment 81960 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=81960&action=review The change looks great an I was tempted to r+/cq+ it but I'm curious about why these fields are needed in order to add CORS support to AssociatedURLLoader. Would you just give a short explanation of this? (I don't need anything in depth just something to give me the idea.) > Source/WebCore/ChangeLog:1 > +2011-02-10 billbudge <bbudge@chromium.org> Is "billbudge" instead of "Bill Budge" intentional?
Bill Budge
Comment 4 2011-02-10 07:59:35 PST
These fields are needed because the WebURLRequest and WebURLResponse classes have these, and they need to get transferred down through the WebCore layers to reach the actual WebURLLoader that the WebKitClient::createURLLoader() method provides. Without this change, .nexe loading didn't work.
Bill Budge
Comment 5 2011-02-10 09:52:10 PST
Created attachment 81996 [details] Proposed Patch Fix my name on the ChangeLog
WebKit Commit Bot
Comment 6 2011-02-10 11:50:49 PST
Comment on attachment 81996 [details] Proposed Patch Clearing flags on attachment: 81996 Committed r78253: <http://trac.webkit.org/changeset/78253>
WebKit Commit Bot
Comment 7 2011-02-10 11:50:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.