Bug 54243

Summary: SVG animation avoid unnecessary adjust for currentColor
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41761    
Attachments:
Description Flags
Patch kling: review+

Dirk Schulze
Reported 2011-02-10 13:48:41 PST
At the moment we check every string for currentColor, independent of the animation type. We should just check for currentColor on color animation. Also if the string is currentColor, we ask the RenderStyle for the color, transform this color to a string and transform it back again.
Attachments
Patch (7.66 KB, patch)
2011-02-10 14:14 PST, Dirk Schulze 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2011-02-10 14:14:43 PST
Created attachment 82047 [details] Patch
Andreas Kling
Comment 2 2011-02-10 14:31:58 PST
Comment on attachment 82047 [details] Patch Nice optimization. r=me In CSS and <canvas> context, "currentColor" is case-insensitive, I don't know about SVG though. Not a regression in your patch, but something to look at afterwards perhaps.
Dirk Schulze
Comment 3 2011-02-10 14:35:03 PST
(In reply to comment #2) > (From update of attachment 82047 [details]) > Nice optimization. r=me > > In CSS and <canvas> context, "currentColor" is case-insensitive, I don't know about SVG though. Not a regression in your patch, but something to look at afterwards perhaps. Checked this right after talking with Andreas. Opera uses case-sensitive, Firefox case-insensitive. Have to take a look into the spec. Thanks for bringing this up.
Dirk Schulze
Comment 4 2011-02-10 14:45:45 PST
Committed r78271: <http://trac.webkit.org/changeset/78271>
Note You need to log in before you can comment on or make changes to this bug.