Bug 54448

Summary: Web Inspector: [Text editor] Add updateHighlight method to the highlighter
Product: WebKit Reporter: Andrey Adaikin <aandrey>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, podivilov, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 53588    
Attachments:
Description Flags
Patch none

Andrey Adaikin
Reported 2011-02-15 04:46:13 PST
We need a method to effectively update existing highlights in the editor. To do that, we should save pre- and post- conditions of the highlighter for each line.
Attachments
Patch (8.83 KB, patch)
2011-02-15 04:50 PST, Andrey Adaikin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrey Adaikin
Comment 1 2011-02-15 04:50:14 PST
Created attachment 82438 [details] Patch
Pavel Feldman
Comment 2 2011-02-17 05:11:02 PST
Comment on attachment 82438 [details] Patch Please test this thoroughly for the cases with nested highlighters. Also, as we agreed offline, you should add tests for highlighter as your next change.
Pavel Podivilov
Comment 3 2011-02-17 05:20:20 PST
Comment on attachment 82438 [details] Patch Clearing flags on attachment: 82438 Committed r78815: <http://trac.webkit.org/changeset/78815>
Pavel Podivilov
Comment 4 2011-02-17 05:20:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.